From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 98846 invoked by alias); 6 Sep 2017 18:43:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 98607 invoked by uid 89); 6 Sep 2017 18:43:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 06 Sep 2017 18:42:57 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 72BBEC04B92C for ; Wed, 6 Sep 2017 18:42:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 72BBEC04B92C Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=keiths@redhat.com Received: from valrhona.uglyboxes.com (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CDE9217D44; Wed, 6 Sep 2017 18:42:55 +0000 (UTC) Subject: Re: [PATCH 2/2] Make "list ambiguous" show symbol names too To: Pedro Alves , gdb-patches@sourceware.org References: <1504550858-27936-1-git-send-email-palves@redhat.com> <1504550858-27936-3-git-send-email-palves@redhat.com> From: Keith Seitz Message-ID: <8e7b55b5-0249-405c-0041-c2fd73da732e@redhat.com> Date: Wed, 06 Sep 2017 18:43:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1504550858-27936-3-git-send-email-palves@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-09/txt/msg00165.txt.bz2 On 09/04/2017 11:47 AM, Pedro Alves wrote: > > Fix that by storing a pointer to the symbol in the sal. :-) > gdb/ChangeLog: > yyyy-mm-dd Pedro Alves > > * cli/cli-cmds.c (list_command): Use print_sal_location. > (print_sal_location): New function. > (ambiguous_line_spec): Use print_sal_location. > * linespec.c (symbol_to_sal): Record the symbol in the sal. > * symtab.c (find_function_start_sal): Likewise. > * symtab.h (symtab_and_line::symbol): New field. > > gdb/testsuite/ChangeLog: > yyyy-mm-dd Pedro Alves > > * gdb.base/list-ambiguous.exp (test_list_ambiguous_symbol): Expect > symbol names in gdb's output. > * gdb.cp/overload.exp ("list all overloads"): Likewise. FWIW, I looked this over and didn't see any problems. Keith