Re: [PATCH 1/2] gdb, multi-target: pass a target argument to prune_threads

[Simon Marchi <simark@simark.ca>]

On 4/17/26 11:16 AM, Andrew Burgess wrote:
> Tankut Baris Aktemur <tankut.baris.aktemur@intel.com> writes:
> 
>> From the way 'prune_threads' is used, it is designed to delete the
>> threads of the current target.  So, while iterating the threads,
>> ignore those that do not belong to the current target.
> 
> I'm not saying that you're wrong, but could you expand on this, maybe
> giving some examples of how it's used and why that suggests it should be
> a per- target operation.
> 
> Did the current code cause some problems?  Is there scope for adding a
> test maybe?
> 
> FWIW: I think this change is probably OK, but the commit message seems a
> little light on detail for my taste.
> 
> Thanks,
> Andrew

I'm not against having more details, but the fact that prune_threads is
called from the various targets' update_thread_list methods (or similar)
is a good clue.  In a multi-target scenario, as the  target updates the
threads it is responsible for, it should not start messing with threads
of other targets.

Simon