From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id biyaL1dT4mmFGB8AWB0awg (envelope-from ) for ; Fri, 17 Apr 2026 11:35:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1776440151; bh=J8jOnWzbjlEajA78qbjF2+Odiuejfg9Si3iGNmYlMnA=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=N0xKAzGSqykaTHFErLJCH6HqvxaLE2EcE8Q+HkQ8d9Ovew1ugYC4Kth7jRFLdu+da U7v8XOccrKLAxabTEXxc8oxy/MfK9DFG7vIus9v+pjYOXdGWQXi6q5sDfexLqm/orz sulBE1qc5Pc8iJaSfCWwmAY/niSnl5IiLFVOCtmE= Received: by simark.ca (Postfix, from userid 112) id A6F621E04F; Fri, 17 Apr 2026 11:35:51 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=k2XOI8Ni; dkim-atps=neutral Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 0AEB11E04F for ; Fri, 17 Apr 2026 11:35:51 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 7F8964CCCA18 for ; Fri, 17 Apr 2026 15:35:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7F8964CCCA18 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=k2XOI8Ni Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 1E7B44BA23CD for ; Fri, 17 Apr 2026 15:35:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1E7B44BA23CD Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1E7B44BA23CD Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776440127; cv=none; b=NyY+cWmmDBQSUvh6CYJBn7hx0MVya+BRCAxl0ieB3iAZIKl47y0kqGCs1O8jnQbuXCU5Op1I6eWz+hjthDk04MVNjWRliR+NaVllM49tIdH9UXAjkDROXjKVFAdx8JtqMSRMJa9NJGeo0g4oz/eL+9jNBdHQHyeP95n9Fu91DKI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776440127; c=relaxed/simple; bh=J8jOnWzbjlEajA78qbjF2+Odiuejfg9Si3iGNmYlMnA=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=VTvVRFARMtVvIScyuNLLwqHMHIDJVLceNQpPVWIuylE9KW2rXrJFauPv9QGJveXb4hNSPRk0DqJrtd3VRVbESCddW4zUjdOyPUUrv379Zz0EvtwteQgFCkHKHftswpCgWTTa2BDysxg2nKYPQEiYKUNKr8UrdH8IUZx+5+7h1x0= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1E7B44BA23CD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1776440126; bh=J8jOnWzbjlEajA78qbjF2+Odiuejfg9Si3iGNmYlMnA=; h=Date:Subject:To:References:From:In-Reply-To:From; b=k2XOI8Niq/U5ZfQPn5qAuV/XouUMpJs23fKzZIRB1OJ1ZSam7HwHi9DEbkCjp6zsn hGJzBgJ4Ni4St04tp3Us91Re8GZyk0LaJZKx8b5JAWfpJ6WdfSlc7yPrEnCsdOOZa3 8oMsOqJYB9+FETreqyHC1ivgix24ON9IajPb8dV4= Received: by simark.ca (Postfix) id 3E34E1E04F; Fri, 17 Apr 2026 11:35:25 -0400 (EDT) Message-ID: <8dfccb11-f39e-4a65-9ca3-ac924597140d@simark.ca> Date: Fri, 17 Apr 2026 11:35:24 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] gdb, multi-target: pass a target argument to prune_threads To: Andrew Burgess , Tankut Baris Aktemur , gdb-patches@sourceware.org References: <20260417111430.4111679-1-tankut.baris.aktemur@intel.com> <87wly5d3bp.fsf@redhat.com> Content-Language: fr From: Simon Marchi In-Reply-To: <87wly5d3bp.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 4/17/26 11:16 AM, Andrew Burgess wrote: > Tankut Baris Aktemur writes: > >> From the way 'prune_threads' is used, it is designed to delete the >> threads of the current target. So, while iterating the threads, >> ignore those that do not belong to the current target. > > I'm not saying that you're wrong, but could you expand on this, maybe > giving some examples of how it's used and why that suggests it should be > a per- target operation. > > Did the current code cause some problems? Is there scope for adding a > test maybe? > > FWIW: I think this change is probably OK, but the commit message seems a > little light on detail for my taste. > > Thanks, > Andrew I'm not against having more details, but the fact that prune_threads is called from the various targets' update_thread_list methods (or similar) is a good clue. In a multi-target scenario, as the target updates the threads it is responsible for, it should not start messing with threads of other targets. Simon