Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Burgess <aburgess@redhat.com>
To: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>,
	gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] gdb, multi-target: pass a target argument to prune_threads
Date: Fri, 17 Apr 2026 16:16:58 +0100	[thread overview]
Message-ID: <87wly5d3bp.fsf@redhat.com> (raw)
In-Reply-To: <20260417111430.4111679-1-tankut.baris.aktemur@intel.com>

Tankut Baris Aktemur <tankut.baris.aktemur@intel.com> writes:

> From the way 'prune_threads' is used, it is designed to delete the
> threads of the current target.  So, while iterating the threads,
> ignore those that do not belong to the current target.

I'm not saying that you're wrong, but could you expand on this, maybe
giving some examples of how it's used and why that suggests it should be
a per- target operation.

Did the current code cause some problems?  Is there scope for adding a
test maybe?

FWIW: I think this change is probably OK, but the commit message seems a
little light on detail for my taste.

Thanks,
Andrew


  reply	other threads:[~2026-04-17 15:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-17 11:14 Tankut Baris Aktemur
2026-04-17 15:16 ` Andrew Burgess [this message]
2026-04-17 15:35   ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wly5d3bp.fsf@redhat.com \
    --to=aburgess@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tankut.baris.aktemur@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox