From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id O1CXEglP4mlhCB8AWB0awg (envelope-from ) for ; Fri, 17 Apr 2026 11:17:29 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=TNv/QFnu; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 3B8891E093; Fri, 17 Apr 2026 11:17:29 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id ADC441E093 for ; Fri, 17 Apr 2026 11:17:28 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 3DF314CCCA1D for ; Fri, 17 Apr 2026 15:17:28 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3DF314CCCA1D Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=TNv/QFnu Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 498D64AA3974 for ; Fri, 17 Apr 2026 15:17:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 498D64AA3974 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 498D64AA3974 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776439023; cv=none; b=l9fM400L+McXq1uTn87VNsBDCBTfWkOXMyIiepslXIj7rHtP18t/6Hy8HIvNbegLdAdiTExAKz9zj079u5ifmOwIsWfR3TDA6UJAygdCpYR/qxc8PF5yVt65fBEVabwfvgTNgxxC9i9mleOj+M8ns5KO4vtoALvOFXcZb73hinI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776439023; c=relaxed/simple; bh=1n/DDE8QOVb6sS5z5SNBzUhMACein+EAGxvgAhNExE0=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=WPoWZhAszCTEzrx1sLWpwOC3M77y4xY7rskuUcNjlf55IPdv9Vx7zVM3IFNJtZmoLN5W5U+DpxBqhLy1OkFG3yZasyZsuSoKMYlEmpSKvRY3QvVmbbx5IytxjQZrBS5NjZC/oAbI17CLfVs3ohDymZzzl3XPeWKqzNcxMPLYoSA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 498D64AA3974 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776439023; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=M7RN6qeadWKvv4RTwOUrTm0SNkSPIAO66aEHD5gKN2o=; b=TNv/QFnuz+JEprepGed4fVPs0RZyHlfv+HY5eTXGDFRitm9YRK0j9Z87DCOCE8PPXk6Tmo 69aaWjPcfcdEPnQ2D5G7A6/mc34iWCRnSy6eQ634CEZgWHwg6H7AxfE/XJul4HTFXHR+NP UBpBhVv4beNsBYUGSWSNRrlqZNi8sR8= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-408-RaS1IMwoPAK7RCPGbvW_4A-1; Fri, 17 Apr 2026 11:17:01 -0400 X-MC-Unique: RaS1IMwoPAK7RCPGbvW_4A-1 X-Mimecast-MFC-AGG-ID: RaS1IMwoPAK7RCPGbvW_4A_1776439020 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-43cfedb10a8so541079f8f.1 for ; Fri, 17 Apr 2026 08:17:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776439020; x=1777043820; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=M7RN6qeadWKvv4RTwOUrTm0SNkSPIAO66aEHD5gKN2o=; b=CdybhpfrXeNflanzIPHQoh1/V/V3ZOhyCEyfCzWaAowfFZz/+qbqyXuK3vIpwpJl0w mlVztJ8NTmKZYbWVTvg66pEtkIfq+1NRwmkC2usHkylal8mAQ3fsetSUS35tGzTxSudz l+cjuuXb7Lp2P5wVQMxhisy72EkIzHlgH2w703qPyLmKF5sZSa3Pa/P2AdqcyWo1lK4o ZbgFqDg8p8RBFDo3k0zRwjmeVx8gSXrn457KVEmInl7T0rQI/2/pYlus4RSeM6AG8RuK wdH21rCugqrCWFgMIe/LnjX8rsQxTaTh9t6z++xHLlshcjXKOUnoBAh/oB6lFVZwP1NP XmvA== X-Forwarded-Encrypted: i=1; AFNElJ/uMPe6PxHfZPKXa7UWBFTAXWop4PxY9nGioGkoMxPnxsT+g/2uMAB1v9uXPYCe+e7tsMATCiSFV4hHIg==@sourceware.org X-Gm-Message-State: AOJu0YznZ/Tzm8bJ94BOSZSCBVTXJDILOPbDq/JavzpHxifdTC+lddft JsarC4FwBEpnxdeI81UjTWNQFBvuy7l1mxK/9GG80eEzdij/DP+vJ8BekJlFLlOS294wANjW5KW le9eodbPPYuxMg6Nps7w3GCNOo/q3wDdU36eRN1wJozj/fBiZQ3O2OYURVMsjLw0GThasODk= X-Gm-Gg: AeBDievUe177Kr7qLFkXONrfKjIalwdlZDEnWbpuYk5jqP22N0tsKUmU9P8ECArascf GVYBarby4K3uC+k+aO4nN2vBBolgdId54duizTs7coHPdYA9eMYtzYwq6qv6CGYPbpV7vzTPpvi y6gvc/ZioJPYIF74ejYdhF/t54cOI84p76l1owY7602dt66j7oJAjdxITrTWD3seLJr/EAv1ZbD vxJgbmGoT13JK0pa2KjiFEqdOhrdCjgh1BwOxjSA6FORBwiES2XaxAKor4q33m4j3FQ1HFgvAhK yBL///Lrc94YE8NY5KugaiOYW0xzgJyzvvolE8w5TkU3UqsZHI4/+O8d19Nr1v3Bi0SepLOycFK kYBzq7VF1sIrotWTL4lRnTTjeYvs= X-Received: by 2002:a05:600c:a404:b0:47e:e2eb:bc22 with SMTP id 5b1f17b1804b1-488fb73b2a3mr43049915e9.5.1776439019978; Fri, 17 Apr 2026 08:16:59 -0700 (PDT) X-Received: by 2002:a05:600c:a404:b0:47e:e2eb:bc22 with SMTP id 5b1f17b1804b1-488fb73b2a3mr43049425e9.5.1776439019520; Fri, 17 Apr 2026 08:16:59 -0700 (PDT) Received: from localhost ([31.111.84.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488fc1cfbf2sm51339035e9.15.2026.04.17.08.16.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Apr 2026 08:16:59 -0700 (PDT) From: Andrew Burgess To: Tankut Baris Aktemur , gdb-patches@sourceware.org Subject: Re: [PATCH 1/2] gdb, multi-target: pass a target argument to prune_threads In-Reply-To: <20260417111430.4111679-1-tankut.baris.aktemur@intel.com> References: <20260417111430.4111679-1-tankut.baris.aktemur@intel.com> Date: Fri, 17 Apr 2026 16:16:58 +0100 Message-ID: <87wly5d3bp.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: iPCgw6JudvYRa0DHzGlK-VV48r36KZu3AckySaO6_Eo_1776439020 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Tankut Baris Aktemur writes: > From the way 'prune_threads' is used, it is designed to delete the > threads of the current target. So, while iterating the threads, > ignore those that do not belong to the current target. I'm not saying that you're wrong, but could you expand on this, maybe giving some examples of how it's used and why that suggests it should be a per- target operation. Did the current code cause some problems? Is there scope for adding a test maybe? FWIW: I think this change is probably OK, but the commit message seems a little light on detail for my taste. Thanks, Andrew