From: Simon Marchi <simark@simark.ca>
To: Philippe Waroquiers <philippe.waroquiers@skynet.be>,
gdb-patches@sourceware.org, Tom Tromey <tom@tromey.com>
Subject: Re: [RFA_v4 2/8] Implement frame apply [all | COUNT | -COUNT | level LEVEL... ] [FLAG]... COMMAND.
Date: Sat, 14 Jul 2018 01:49:00 -0000 [thread overview]
Message-ID: <8cb0cf0e-7b41-407b-3ba1-6a7be1a65417@simark.ca> (raw)
In-Reply-To: <20180710213926.32240-3-philippe.waroquiers@skynet.be>
Hi Philippe,
On 2018-07-10 05:39 PM, Philippe Waroquiers wrote:
> +/* Implementation of the "frame apply level" command. */
> +
> +static void
> +frame_apply_level_command (const char *cmd, int from_tty)
> +{
> + if (!target_has_stack)
> + error (_("No stack."));
> +
> + bool level_found = false;
> + const char *levels_str = cmd;
> + number_or_range_parser levels (levels_str);
> +
> + /* Skip the LEVEL list to find the flags and command args. */
> + while (!levels.finished ())
> + {
> + const int level_beg = levels.get_number ();
This variable is unused, so is caught by Tom's -Wunused-variable patch.
Is it just ok to remove the local variable and the assignment (but keep
the call)?
Simon
next prev parent reply other threads:[~2018-07-14 1:49 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-10 21:39 [RFA_v4 0/8] Implement 'frame apply COMMAND', enhance 'thread apply COMMAND' Philippe Waroquiers
2018-07-10 21:39 ` [RFA_v4 8/8] Add a self-test for cli-utils.c Philippe Waroquiers
2018-07-10 21:39 ` [RFA_v4 4/8] Documents the new commands 'frame apply', faas, taas, tfaas Philippe Waroquiers
2018-07-11 3:06 ` Eli Zaretskii
2018-07-11 5:57 ` Philippe Waroquiers
2018-07-10 21:39 ` [RFA_v4 1/8] Add helper functions parse_flags and parse_flags_qcs Philippe Waroquiers
2018-07-30 20:16 ` Joel Brobecker
2018-07-30 21:10 ` Tom Tromey
2018-07-31 13:52 ` Joel Brobecker
2018-07-31 15:41 ` Tom Tromey
2018-07-31 21:13 ` Philippe Waroquiers
2018-08-01 4:04 ` Tom Tromey
2018-08-01 4:34 ` Tom Tromey
2018-07-30 21:48 ` Philippe Waroquiers
2018-07-10 21:39 ` [RFA_v4 6/8] Add a test for 'frame apply' Philippe Waroquiers
2018-07-10 21:39 ` [RFA_v4 5/8] Announce the user visible changes for frame/thread apply in NEWS Philippe Waroquiers
2018-07-10 21:39 ` [RFA_v4 2/8] Implement frame apply [all | COUNT | -COUNT | level LEVEL... ] [FLAG]... COMMAND Philippe Waroquiers
2018-07-14 1:49 ` Simon Marchi [this message]
2018-07-14 12:37 ` Tom Tromey
2018-07-10 21:39 ` [RFA_v4 7/8] Modify gdb.threads/pthreads.exp to test FLAG qcs arguments for thread apply. Also, add prefixes to make some non unique tests unique Philippe Waroquiers
2018-07-10 21:39 ` [RFA_v4 3/8] Add [FLAG]... arguments to 'thread apply' Philippe Waroquiers
2018-07-11 10:58 ` [RFA_v4 0/8] Implement 'frame apply COMMAND', enhance 'thread apply COMMAND' Pedro Alves
2018-07-12 21:12 ` Philippe Waroquiers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8cb0cf0e-7b41-407b-3ba1-6a7be1a65417@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=philippe.waroquiers@skynet.be \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox