From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 47343 invoked by alias); 14 Jul 2018 01:49:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 46763 invoked by uid 89); 14 Jul 2018 01:49:39 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=sk:frame_a, Hx-languages-length:800 X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 14 Jul 2018 01:49:38 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 37D201E093; Fri, 13 Jul 2018 21:49:34 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=simark.ca; s=mail; t=1531532976; bh=U6mGn1+glx9vh45mXLgNe/mhcZW8KQA+zhikuvol4ZM=; h=Subject:To:References:From:Date:In-Reply-To:From; b=NbibmTKIKuISKf823ORuLyjyXIrrNvyCTCsuSO6mGoGjZhT7JBJYBLlKHknDzKZGM E4I10WWtDCnUOW1ZMdPan3RFqSTJyVdK1WfijjvaGv0/803ENT7yE6kH/HkMMi4u/B 3pZRwMe1D//3wTgb95ZxUuKBU6H6WRxeHuykD8K8= Subject: Re: [RFA_v4 2/8] Implement frame apply [all | COUNT | -COUNT | level LEVEL... ] [FLAG]... COMMAND. To: Philippe Waroquiers , gdb-patches@sourceware.org, Tom Tromey References: <20180710213926.32240-1-philippe.waroquiers@skynet.be> <20180710213926.32240-3-philippe.waroquiers@skynet.be> From: Simon Marchi Message-ID: <8cb0cf0e-7b41-407b-3ba1-6a7be1a65417@simark.ca> Date: Sat, 14 Jul 2018 01:49:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180710213926.32240-3-philippe.waroquiers@skynet.be> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-07/txt/msg00444.txt.bz2 Hi Philippe, On 2018-07-10 05:39 PM, Philippe Waroquiers wrote: > +/* Implementation of the "frame apply level" command. */ > + > +static void > +frame_apply_level_command (const char *cmd, int from_tty) > +{ > + if (!target_has_stack) > + error (_("No stack.")); > + > + bool level_found = false; > + const char *levels_str = cmd; > + number_or_range_parser levels (levels_str); > + > + /* Skip the LEVEL list to find the flags and command args. */ > + while (!levels.finished ()) > + { > + const int level_beg = levels.get_number (); This variable is unused, so is caught by Tom's -Wunused-variable patch. Is it just ok to remove the local variable and the assignment (but keep the call)? Simon