From: Philippe Waroquiers <philippe.waroquiers@skynet.be>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA_v4 4/8] Documents the new commands 'frame apply', faas, taas, tfaas
Date: Wed, 11 Jul 2018 05:57:00 -0000 [thread overview]
Message-ID: <1531288671.4602.1.camel@skynet.be> (raw)
In-Reply-To: <83sh4qfp3t.fsf@gnu.org>
On Wed, 2018-07-11 at 06:06 +0300, Eli Zaretskii wrote:
> > From: Philippe Waroquiers <philippe.waroquiers@skynet.be>
> > Cc: Philippe Waroquiers <philippe.waroquiers@skynet.be>
> > Date: Tue, 10 Jul 2018 23:39:22 +0200
> >
> > gdb/doc/ChangeLog
> > 2018-07-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
> >
> > * gdb.texinfo (Debugging Programs with Multiple Threads):
> > Document changes to 'thread apply'. Document 'taas'.
>
> ^^
> Two spaces between sentences, please.
Thanks, fixed.
(I am now running a bunch of grep on git diff to help finding
the above errors, but I need also to grep the commit
messages).
>
> I believe I already approved the rest. Thanks.
Yes, doc/NEWS/on-line help were previously approved on RFA_v2.
Between RFA_v2 and this RFA_v4, some non minor changes were done
e.g. to the new FLAG arguments of 'frame apply' and 'thread apply',
but I saw no explicit re-approval of NEWS and on-line help doc
strings.
(I assume this mail re-approves the doc part RFA_v4, but in any
case a re-review of the code is needed before push of the series).
Thanks
Philippe
next prev parent reply other threads:[~2018-07-11 5:57 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-10 21:39 [RFA_v4 0/8] Implement 'frame apply COMMAND', enhance 'thread apply COMMAND' Philippe Waroquiers
2018-07-10 21:39 ` [RFA_v4 5/8] Announce the user visible changes for frame/thread apply in NEWS Philippe Waroquiers
2018-07-10 21:39 ` [RFA_v4 6/8] Add a test for 'frame apply' Philippe Waroquiers
2018-07-10 21:39 ` [RFA_v4 1/8] Add helper functions parse_flags and parse_flags_qcs Philippe Waroquiers
2018-07-30 20:16 ` Joel Brobecker
2018-07-30 21:10 ` Tom Tromey
2018-07-31 13:52 ` Joel Brobecker
2018-07-31 15:41 ` Tom Tromey
2018-07-31 21:13 ` Philippe Waroquiers
2018-08-01 4:04 ` Tom Tromey
2018-08-01 4:34 ` Tom Tromey
2018-07-30 21:48 ` Philippe Waroquiers
2018-07-10 21:39 ` [RFA_v4 4/8] Documents the new commands 'frame apply', faas, taas, tfaas Philippe Waroquiers
2018-07-11 3:06 ` Eli Zaretskii
2018-07-11 5:57 ` Philippe Waroquiers [this message]
2018-07-10 21:39 ` [RFA_v4 8/8] Add a self-test for cli-utils.c Philippe Waroquiers
2018-07-10 21:39 ` [RFA_v4 3/8] Add [FLAG]... arguments to 'thread apply' Philippe Waroquiers
2018-07-10 21:39 ` [RFA_v4 7/8] Modify gdb.threads/pthreads.exp to test FLAG qcs arguments for thread apply. Also, add prefixes to make some non unique tests unique Philippe Waroquiers
2018-07-10 21:39 ` [RFA_v4 2/8] Implement frame apply [all | COUNT | -COUNT | level LEVEL... ] [FLAG]... COMMAND Philippe Waroquiers
2018-07-14 1:49 ` Simon Marchi
2018-07-14 12:37 ` Tom Tromey
2018-07-11 10:58 ` [RFA_v4 0/8] Implement 'frame apply COMMAND', enhance 'thread apply COMMAND' Pedro Alves
2018-07-12 21:12 ` Philippe Waroquiers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1531288671.4602.1.camel@skynet.be \
--to=philippe.waroquiers@skynet.be \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox