From: Simon Marchi <simark@simark.ca>
To: Guinevere Larsen <guinevere@redhat.com>,
Simon Marchi <simon.marchi@efficios.com>,
gdb-patches@sourceware.org
Subject: Re: [PATCH v2 4/4] gdb/solib: C++ify solib_ops
Date: Thu, 12 Jun 2025 11:02:07 -0400 [thread overview]
Message-ID: <8c7600db-c8b6-42b5-99b9-63b2698948bb@simark.ca> (raw)
In-Reply-To: <fa840ac6-b0c1-41f4-ba87-9d0b5b326aac@redhat.com>
On 2025-06-12 08:56, Guinevere Larsen wrote:
> Hi!
>
> I took a look over the entire series and the code looks good, and many of the changes are very good. I don't really feel like I can properly review this patch though, but I did ran it through aarch64 and ppc64le, and I see no issues, so
>
> Tested-By: Guinevere Larsen <guinevere@redhat.com>
Great, thanks a lot for your testing?
Simon
prev parent reply other threads:[~2025-06-12 15:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-09 19:40 [PATCH v2 1/4] gdb/solib: add solib -> solib_ops backlink Simon Marchi
2025-06-09 19:40 ` [PATCH v2 2/4] gdb/solib: use solib::ops for operations that concern a single solib Simon Marchi
2025-06-09 19:40 ` [PATCH v2 3/4] gdb/progspace: add solib_ops pointer in program_space Simon Marchi
2025-06-11 18:14 ` Guinevere Larsen
2025-06-11 18:43 ` Simon Marchi
2025-06-16 18:41 ` Simon Marchi
2025-06-16 18:53 ` Simon Marchi
2025-06-16 19:38 ` Guinevere Larsen
2025-06-16 19:41 ` Simon Marchi
2025-06-09 19:40 ` [PATCH v2 4/4] gdb/solib: C++ify solib_ops Simon Marchi
2025-06-12 12:56 ` Guinevere Larsen
2025-06-12 15:02 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c7600db-c8b6-42b5-99b9-63b2698948bb@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=guinevere@redhat.com \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox