From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id BViKFhLsSmjuJQsAWB0awg (envelope-from ) for ; Thu, 12 Jun 2025 11:02:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1749740562; bh=1Gofa8E6NZLbjnVVgh19RyAy7fS/OmTR0iPHiezYr8M=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=t+BscriIqy9mclhylktGr4Q1dgLOYnzCu/cfQuJX6oYPtwpSXC7usgevE3dnttjls KNNXUl88fEo9O4y3e29r/jh0+LUGY381WMfQewijJXOTiE+gfYUPXZywlECi5KdR0N 0nvXuNUuKmFQd5xjV87yOTkReFSOWdeFQrHdMEd4= Received: by simark.ca (Postfix, from userid 112) id 431CE1E102; Thu, 12 Jun 2025 11:02:42 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-9.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE autolearn=unavailable autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=ItSEusA0; dkim=pass (1024-bit key) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=JMsBeq/c; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 94F831E089 for ; Thu, 12 Jun 2025 11:02:41 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DAC48394B896 for ; Thu, 12 Jun 2025 15:02:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DAC48394B896 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=ItSEusA0; dkim=pass (1024-bit key) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=JMsBeq/c Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id C1D2C38184E4 for ; Thu, 12 Jun 2025 15:02:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C1D2C38184E4 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C1D2C38184E4 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1749740529; cv=none; b=fgXaF44t4LitTtKd0Z+Hn3iRflAQWRu2VsezQa8BSHrw/gaPA5desu+yPWR3fc5GmM6xdWizxGwNUfgctIUl+a0FuuBo0c5PM0YWZ6/k7oxSDIfWT+M/mKuJWKVcKL2Deph2eZ+O3isNA9wTdvnygtPfYiJek2abgimHHTmhhEI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1749740529; c=relaxed/simple; bh=1Gofa8E6NZLbjnVVgh19RyAy7fS/OmTR0iPHiezYr8M=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:MIME-Version: Subject:To:From; b=Y/6iEgtDYMWBr4R4T8psni9VCGQbg6u5y9jWrgQN4mWNowZ2jtjvDWVn/QUcDrx6wohfaksftnygSl3/4R1wqpGrZEo9eE5jXQuZT3A3BGSOD54gOE6uwOoFANIVxkIGJsCui9E0ZP8K+pmLtw5zaQnNCauYkmra0k4zKSEfJqs= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C1D2C38184E4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1749740529; bh=1Gofa8E6NZLbjnVVgh19RyAy7fS/OmTR0iPHiezYr8M=; h=Date:Subject:To:References:From:In-Reply-To:From; b=ItSEusA0jJwcWmyM5fikCNGuZRQGW5yEdFB5cNRzXY+qVtZ79x+22cH8mdxUKxGGB tIlSWFemSOTKG2asKyAQv5YzxP2TseNjZWblUvGBYPZfatgc+oqWU5pIHi9lnThdav SeiVRHXaOBxyXt7scJpyH5MsqhTnygaXt8Aegiow= Received: by simark.ca (Postfix, from userid 112) id 2AE971E126; Thu, 12 Jun 2025 11:02:09 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1749740527; bh=1Gofa8E6NZLbjnVVgh19RyAy7fS/OmTR0iPHiezYr8M=; h=Date:Subject:To:References:From:In-Reply-To:From; b=JMsBeq/cBZRL2amj/QamB1x48pfgGBiGBdw5gC6GjdtgrJiJzM5FM/lr8t1vtKjZn V/f9t6TZdBOuYAkmsVa4NYA0vTo0C3D3tONlJl+05Y98oqPm7BpvYmd0EaarT4eHqr I9hMRBrrzI2TMpDRAlZmo5safILOoG+HJajKU4es= Received: from [10.0.0.11] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 695701E089; Thu, 12 Jun 2025 11:02:07 -0400 (EDT) Message-ID: <8c7600db-c8b6-42b5-99b9-63b2698948bb@simark.ca> Date: Thu, 12 Jun 2025 11:02:07 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/4] gdb/solib: C++ify solib_ops To: Guinevere Larsen , Simon Marchi , gdb-patches@sourceware.org References: <20250609194146.137730-1-simon.marchi@efficios.com> <20250609194146.137730-4-simon.marchi@efficios.com> Content-Language: en-US From: Simon Marchi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2025-06-12 08:56, Guinevere Larsen wrote: > Hi! > > I took a look over the entire series and the code looks good, and many of the changes are very good. I don't really feel like I can properly review this patch though, but I did ran it through aarch64 and ppc64le, and I see no issues, so > > Tested-By: Guinevere Larsen Great, thanks a lot for your testing? Simon