From: Simon Marchi <simon.marchi@efficios.com>
To: Guinevere Larsen <guinevere@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v2 3/4] gdb/progspace: add solib_ops pointer in program_space
Date: Mon, 16 Jun 2025 15:41:43 -0400 [thread overview]
Message-ID: <fa819ebe-2e90-4456-97d7-4661635521ea@efficios.com> (raw)
In-Reply-To: <8795ae3d-7ffd-41b5-b4d9-4d9c2da1cee0@redhat.com>
On 6/16/25 3:38 PM, Guinevere Larsen wrote:
> Ok, this makes sense. I guess i had the wrong mental model for when
> m_solib_ops would be set, I didn't think that using commands before
> starting an inferior would have a null pointer.
Was your mental model that there was always an solib_ops? I guess I
could have done it this way, it would be close to what we have now. But
I'm not sure it's really useful. As far as I know, an solib_ops doesn't
provide anything useful when the inferior isn't running yet.
> We should be fine to leave things like this, but this would be a nice
> improvement in the future to try and figure out where we can be sure
> of things, or even where we can make checks earlier to enforce things
> only happening after solib_ops has been set.
Agreed, I just wouldn't rush it.
Simon
next prev parent reply other threads:[~2025-06-16 19:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-09 19:40 [PATCH v2 1/4] gdb/solib: add solib -> solib_ops backlink Simon Marchi
2025-06-09 19:40 ` [PATCH v2 2/4] gdb/solib: use solib::ops for operations that concern a single solib Simon Marchi
2025-06-09 19:40 ` [PATCH v2 3/4] gdb/progspace: add solib_ops pointer in program_space Simon Marchi
2025-06-11 18:14 ` Guinevere Larsen
2025-06-11 18:43 ` Simon Marchi
2025-06-16 18:41 ` Simon Marchi
2025-06-16 18:53 ` Simon Marchi
2025-06-16 19:38 ` Guinevere Larsen
2025-06-16 19:41 ` Simon Marchi [this message]
2025-06-09 19:40 ` [PATCH v2 4/4] gdb/solib: C++ify solib_ops Simon Marchi
2025-06-12 12:56 ` Guinevere Larsen
2025-06-12 15:02 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa819ebe-2e90-4456-97d7-4661635521ea@efficios.com \
--to=simon.marchi@efficios.com \
--cc=gdb-patches@sourceware.org \
--cc=guinevere@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox