Re: [PATCH] configure.ac: Cygwin now has ncurses not termcap. Use standard logic.

[Pedro Alves <palves@redhat.com>]

On 10/25/2018 04:01 PM, Joel Sherrill wrote:
> On Thu, Oct 25, 2018 at 9:34 AM Pedro Alves <palves@redhat.com> wrote:
> 
>> WDTY by "now"?
>>
>> I mean Cygwin used to include libtermcap and this built. I updated my
> Cygwin this
> week and it is no longer there. I wasn't able to figure out when it went
> away. libncurses.a
> is included and that's suitable.
> 

That's so much clearer.

> I cc'ed Corinna. I assume she can speak to when libtermcap.a was removed.
> 
> Corring
> 
> 
>> Could you add some rationale words to the proposed commit log, please?
>>
> 
> Like what? This removes a hack that was dependent on the presence of one
> of the multiple alternative libraries. And the one it was hard-coded to
> pick isn't
> included with Cygwin anymore.

That too is useful information.

> 
> Happy to change the text but it felt like I was removing a hack that had
> outlived
> its usefulness. :)

And that too.

The problem is that you had no text at all beyond the ChangeLog.  See:

 https://sourceware.org/gdb/wiki/ContributionChecklist#Detailed_Explanation_of_the_Patch

Particularly, 3.1, first bullet.

Thanks,
Pedro Alves