Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Sherrill <joel@rtems.org>
To: palves@redhat.com, Corinna Vinschen <vinschen@redhat.com>
Cc: GDB patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] configure.ac: Cygwin now has ncurses not termcap. Use standard logic.
Date: Thu, 25 Oct 2018 15:02:00 -0000	[thread overview]
Message-ID: <CAF9ehCVT83HXak+a6BS7qW4TG-yj2fWA9uEoB_E63OO-Xt3gTQ@mail.gmail.com> (raw)
In-Reply-To: <f417f573-08dc-38ea-adaa-b079755b2e78@redhat.com>

On Thu, Oct 25, 2018 at 9:34 AM Pedro Alves <palves@redhat.com> wrote:

> WDTY by "now"?
>
> I mean Cygwin used to include libtermcap and this built. I updated my
Cygwin this
week and it is no longer there. I wasn't able to figure out when it went
away. libncurses.a
is included and that's suitable.

I cc'ed Corinna. I assume she can speak to when libtermcap.a was removed.

Corring


> Could you add some rationale words to the proposed commit log, please?
>

Like what? This removes a hack that was dependent on the presence of one
of the multiple alternative libraries. And the one it was hard-coded to
pick isn't
included with Cygwin anymore.

Happy to change the text but it felt like I was removing a hack that had
outlived
its usefulness. :)

--joel


>
> Thanks,
> Pedro Alves
>


  reply	other threads:[~2018-10-25 15:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-24 21:07 Joel Sherrill
2018-10-25 14:34 ` Pedro Alves
2018-10-25 15:02   ` Joel Sherrill [this message]
2018-10-25 15:31     ` Pedro Alves
2018-10-25 18:50       ` Corinna Vinschen
     [not found]         ` <16e94ff1-0c06-7cca-44b1-77bf2fa59519@redhat.com>
2018-10-30 20:22           ` Corinna Vinschen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAF9ehCVT83HXak+a6BS7qW4TG-yj2fWA9uEoB_E63OO-Xt3gTQ@mail.gmail.com \
    --to=joel@rtems.org \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    --cc=vinschen@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox