From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 77158 invoked by alias); 25 Oct 2018 15:31:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 76875 invoked by uid 89); 25 Oct 2018 15:30:54 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Happy, cced, Hx-languages-length:1210 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 25 Oct 2018 15:30:53 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 11DD583F46; Thu, 25 Oct 2018 15:30:48 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id CFD4960BB2; Thu, 25 Oct 2018 15:30:46 +0000 (UTC) Subject: Re: [PATCH] configure.ac: Cygwin now has ncurses not termcap. Use standard logic. To: joel@rtems.org, Corinna Vinschen References: <1540415244-4879-1-git-send-email-joel@rtems.org> Cc: GDB patches From: Pedro Alves Message-ID: <8bc11746-527b-b123-0879-0c4cbd81eda3@redhat.com> Date: Thu, 25 Oct 2018 15:31:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-10/txt/msg00582.txt.bz2 On 10/25/2018 04:01 PM, Joel Sherrill wrote: > On Thu, Oct 25, 2018 at 9:34 AM Pedro Alves wrote: > >> WDTY by "now"? >> >> I mean Cygwin used to include libtermcap and this built. I updated my > Cygwin this > week and it is no longer there. I wasn't able to figure out when it went > away. libncurses.a > is included and that's suitable. > That's so much clearer. > I cc'ed Corinna. I assume she can speak to when libtermcap.a was removed. > > Corring > > >> Could you add some rationale words to the proposed commit log, please? >> > > Like what? This removes a hack that was dependent on the presence of one > of the multiple alternative libraries. And the one it was hard-coded to > pick isn't > included with Cygwin anymore. That too is useful information. > > Happy to change the text but it felt like I was removing a hack that had > outlived > its usefulness. :) And that too. The problem is that you had no text at all beyond the ChangeLog. See: https://sourceware.org/gdb/wiki/ContributionChecklist#Detailed_Explanation_of_the_Patch Particularly, 3.1, first bullet. Thanks, Pedro Alves