Re: [PATCH] Update more types for section index change

[Simon Marchi <simark@simark.ca>]

On 9/13/24 12:41 AM, Kevin Buettner wrote:
> On Thu, 12 Sep 2024 20:11:54 -0600
> Tom Tromey <tom@tromey.com> wrote:
> 
>> Commit f89276a2f3e ("change type of `general_symbol_info::m_section`
>> to int") did what it says in the title -- changed the type of the
>> section index from short to int.  However, it seems incomplete, in
>> that there are uses of the section index that use the type 'short'.
>>
>> This patch fixes the ones I found, first by searching for
>> "short.*sect" and then by looking at all the callers of section_index
>> (and then functions called with the resulting value) just to try to be
>> more sure.
>> ---
>>  gdb/coff-pe-read.c | 3 +--
>>  gdb/ctfread.c      | 2 +-
>>  gdb/mdebugread.c   | 4 ++--
>>  gdb/minsyms.c      | 3 +--
>>  gdb/psymtab.c      | 2 +-
>>  gdb/psymtab.h      | 2 +-
>>  6 files changed, 7 insertions(+), 9 deletions(-)
> 
> LGTM.
> 
> Approved-by: Kevin Buettner <kevinb@redhat.com>

LGTM as well, thanks.

Approved-By: Simon Marchi <simon.marchi@efficios.com>

Simon