From: Kevin Buettner <kevinb@redhat.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Update more types for section index change
Date: Thu, 12 Sep 2024 21:41:16 -0700 [thread overview]
Message-ID: <20240912214116.1bca227b@f40-zbm-amd> (raw)
In-Reply-To: <20240913021154.1458345-1-tom@tromey.com>
On Thu, 12 Sep 2024 20:11:54 -0600
Tom Tromey <tom@tromey.com> wrote:
> Commit f89276a2f3e ("change type of `general_symbol_info::m_section`
> to int") did what it says in the title -- changed the type of the
> section index from short to int. However, it seems incomplete, in
> that there are uses of the section index that use the type 'short'.
>
> This patch fixes the ones I found, first by searching for
> "short.*sect" and then by looking at all the callers of section_index
> (and then functions called with the resulting value) just to try to be
> more sure.
> ---
> gdb/coff-pe-read.c | 3 +--
> gdb/ctfread.c | 2 +-
> gdb/mdebugread.c | 4 ++--
> gdb/minsyms.c | 3 +--
> gdb/psymtab.c | 2 +-
> gdb/psymtab.h | 2 +-
> 6 files changed, 7 insertions(+), 9 deletions(-)
LGTM.
Approved-by: Kevin Buettner <kevinb@redhat.com>
next prev parent reply other threads:[~2024-09-13 4:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-13 2:11 Tom Tromey
2024-09-13 4:41 ` Kevin Buettner [this message]
2024-09-13 11:38 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240912214116.1bca227b@f40-zbm-amd \
--to=kevinb@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox