From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id GCavBIrC42aebCkAWB0awg (envelope-from ) for ; Fri, 13 Sep 2024 00:41:46 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=HfF+QTxP; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id E40041E353; Fri, 13 Sep 2024 00:41:45 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-12.8 required=5.0 tests=ARC_SIGNED,ARC_VALID, BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,RCVD_IN_VALIDITY_CERTIFIED, RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4691D1E05C for ; Fri, 13 Sep 2024 00:41:45 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 91CC93858C78 for ; Fri, 13 Sep 2024 04:41:44 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id B7E4A3858D26 for ; Fri, 13 Sep 2024 04:41:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B7E4A3858D26 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B7E4A3858D26 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1726202486; cv=none; b=W91os3liELRGS/mysTsTpbAR0Cay4UXBvur8esy780pYvPayegR2aWTgY6zA2rmJ/J9RdAEONXOoqfr0FhKJE2l7DfV/lSxXJTmLCB0q7Rli0aJTp7RgwXpUVh1vHLZkljB7H0BsCkmehUKDb+Ap+zHa4PRyd0NFipBI/ao97hE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1726202486; c=relaxed/simple; bh=RW1idD/V0jjfE4b5y7FHogQGIhS/GSdD7kjEIAAibKw=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=Q8eDcIiARC3r+PhoViqRwPFVCSV9lV+AHL+lPiCdugqjFMv1NPHNSyrijvXcaOblE8VRJ3myxMva5+0TS0BR+wX1cTDOhDm7U+Dm0S63ibjrr8REtCn/+kC9XVW63A1g8StEjpKVWsj83KZ9l7iJQKt3BuSErK/twAbScFrXGI4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1726202484; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wip11HtY/KYp0ZidU3yqfogYMATus7VzP5V0DRIivO0=; b=HfF+QTxP1B7oMnEHg8yCl6EdvHoaefyJme4sRLFG5kq9dN5QNH7yDlViiAFT/taontxLXG y8zbJ47oTURJpt5GdedjbzwwiBwRFtCaF/oX+5G3RkrV3kXY3xebCx9vYCQfFXOSNeNG3+ 5K7gcW7gnsL4VvF/hutkatkT4UGdF8s= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-635-N6ALVIxwONKECgV1_I0GcA-1; Fri, 13 Sep 2024 00:41:23 -0400 X-MC-Unique: N6ALVIxwONKECgV1_I0GcA-1 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 38CC41955F42; Fri, 13 Sep 2024 04:41:22 +0000 (UTC) Received: from f40-zbm-amd (unknown [10.22.65.0]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 52A9319560AA; Fri, 13 Sep 2024 04:41:20 +0000 (UTC) Date: Thu, 12 Sep 2024 21:41:16 -0700 From: Kevin Buettner To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Update more types for section index change Message-ID: <20240912214116.1bca227b@f40-zbm-amd> In-Reply-To: <20240913021154.1458345-1-tom@tromey.com> References: <20240913021154.1458345-1-tom@tromey.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Thu, 12 Sep 2024 20:11:54 -0600 Tom Tromey wrote: > Commit f89276a2f3e ("change type of `general_symbol_info::m_section` > to int") did what it says in the title -- changed the type of the > section index from short to int. However, it seems incomplete, in > that there are uses of the section index that use the type 'short'. > > This patch fixes the ones I found, first by searching for > "short.*sect" and then by looking at all the callers of section_index > (and then functions called with the resulting value) just to try to be > more sure. > --- > gdb/coff-pe-read.c | 3 +-- > gdb/ctfread.c | 2 +- > gdb/mdebugread.c | 4 ++-- > gdb/minsyms.c | 3 +-- > gdb/psymtab.c | 2 +- > gdb/psymtab.h | 2 +- > 6 files changed, 7 insertions(+), 9 deletions(-) LGTM. Approved-by: Kevin Buettner