From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ejJJB0Uk5GZetykAWB0awg (envelope-from ) for ; Fri, 13 Sep 2024 07:38:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1726227524; bh=Gc3ynAgMjaiCFK/oeV5c/XqiKzm7wS9ttfedZF581zc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=OCWOMMkdeqFgOXB4k+24Cxw47p9Ek5znJ3Yx096H8kGlDXq7qmn0gpWdo7gtjd/pl zjJML4/1+FbEfDKSdREZLmt5G0LlfQ/sZWwAc/Znb9Wqnm8jFJNJMW0E9Dy3jPK0Q7 Yt+WlE40qrYj8kgzaGFAX0cl22XhfGjCIgBecdeI= Received: by simark.ca (Postfix, from userid 112) id EEAAC1E353; Fri, 13 Sep 2024 07:38:44 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-11.8 required=5.0 tests=ARC_SIGNED,ARC_VALID, BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE,URIBL_BLOCKED,URIBL_DBL_BLOCKED_OPENDNS autolearn=unavailable autolearn_force=no version=4.0.0 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=V7YJh0bt; dkim=pass (1024-bit key) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=wuFuaZ15; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 523751E05C for ; Fri, 13 Sep 2024 07:38:44 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C012F3858283 for ; Fri, 13 Sep 2024 11:38:43 +0000 (GMT) Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id E22EE3858D28 for ; Fri, 13 Sep 2024 11:38:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E22EE3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E22EE3858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1726227507; cv=none; b=V5cIB3RMpiQC/Qmwk32oUIlNwnvSTsPcLFhoOm+1KlFmBl29lYBicU6YvOrl32St/TbN4vVf3XZJCd2RLiP1Ln3goD9lwS1Z8S3smlsSyaS4/oUqYm8wcLwdI8tY8m1dNGUvKHXPTIORQYIHxrOXyEe8qur2siM0xihk/OdkA1w= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1726227507; c=relaxed/simple; bh=Gc3ynAgMjaiCFK/oeV5c/XqiKzm7wS9ttfedZF581zc=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:MIME-Version: Subject:To:From; b=qEYH4C3BOYQKfouNDLfSgCR2B98Wh76VjnnixVhsmceieLX6c8u7pDwwZg6EdoTNwopOPzDvU4/YRGErtzqlh0sq8U+tdjOd+V1ZdVUClRUlEQu/srxIS/OXuoL25kD7s2TofmqIsAp48lrMT03VFQpMvFagOAnC/Ib0b+cf0rg= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1726227504; bh=Gc3ynAgMjaiCFK/oeV5c/XqiKzm7wS9ttfedZF581zc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=V7YJh0btUbdHu/kSnlveJJSsPo3adb4tjYLl2YQmPTOs1ETprxxkEyG5OiwRS86hb RZc9pHuQMORpsVzJqCUNYKuu0vC1ILUhkD2ZvP5uhIzUykRdEkLgZDlPitkaMJrfgL 5lHMpqsGgTMeQdCd4GkOuGrUmyMz1plzoiDgIMWk= Received: by simark.ca (Postfix, from userid 112) id 3BAE31E355; Fri, 13 Sep 2024 07:38:24 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1726227502; bh=Gc3ynAgMjaiCFK/oeV5c/XqiKzm7wS9ttfedZF581zc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=wuFuaZ15ECNipw6fxlCyJBOOjjFabVS4ZOt2VX47aOxXGkr4lOachVAdmGsfaTbmb WmWMRKSfDIaZit/ayEiF4ffKx2i5c2FztY2GQZF4MJwWtdM+inNE77z4LwPUEELafH xXobtVg2P7xUAUzBr97d4lquGCJKKTu+537OZDQE= Received: from [192.168.0.103] (unknown [109.183.98.80]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 525941E05C; Fri, 13 Sep 2024 07:38:21 -0400 (EDT) Message-ID: <8af82b22-86a3-4cdd-94c8-384a17c799c0@simark.ca> Date: Fri, 13 Sep 2024 07:38:18 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Update more types for section index change To: Kevin Buettner , Tom Tromey Cc: gdb-patches@sourceware.org References: <20240913021154.1458345-1-tom@tromey.com> <20240912214116.1bca227b@f40-zbm-amd> Content-Language: fr From: Simon Marchi In-Reply-To: <20240912214116.1bca227b@f40-zbm-amd> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 9/13/24 12:41 AM, Kevin Buettner wrote: > On Thu, 12 Sep 2024 20:11:54 -0600 > Tom Tromey wrote: > >> Commit f89276a2f3e ("change type of `general_symbol_info::m_section` >> to int") did what it says in the title -- changed the type of the >> section index from short to int. However, it seems incomplete, in >> that there are uses of the section index that use the type 'short'. >> >> This patch fixes the ones I found, first by searching for >> "short.*sect" and then by looking at all the callers of section_index >> (and then functions called with the resulting value) just to try to be >> more sure. >> --- >> gdb/coff-pe-read.c | 3 +-- >> gdb/ctfread.c | 2 +- >> gdb/mdebugread.c | 4 ++-- >> gdb/minsyms.c | 3 +-- >> gdb/psymtab.c | 2 +- >> gdb/psymtab.h | 2 +- >> 6 files changed, 7 insertions(+), 9 deletions(-) > > LGTM. > > Approved-by: Kevin Buettner LGTM as well, thanks. Approved-By: Simon Marchi Simon