From: Paul Pluzhnikov <ppluzhnikov@google.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Fix for PR gdb/11022
Date: Wed, 02 Dec 2009 19:37:00 -0000 [thread overview]
Message-ID: <8ac60eac0912021137u451d942h39a3594e6502bbdb@mail.gmail.com> (raw)
In-Reply-To: <20091126212111.GB18125@adacore.com>
On Thu, Nov 26, 2009 at 1:21 PM, Joel Brobecker <brobecker@adacore.com> wrote:
>> PR gdb/11022
>>
>> * breakpoint.c (invalidate_bp_value_on_memory_change):
>> New function.
>> (_initialize_breakpoint): Add it as memory change observer.
>
> Seems fine to me, but I have become more and more unfamiliar with
> this area, not having been involved with it for a while. So let's wait
> a week or so to see if anyone has any comment, and then it can go in.
I'll commit this later today, if there are no other comments.
>> + j = 0; // break here
> Can you use C-style comments, here (since this is a C file)?
With the C-style comment correction.
Thanks,
--
Paul Pluzhnikov
next prev parent reply other threads:[~2009-12-02 19:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-25 23:46 Paul Pluzhnikov
2009-11-26 21:21 ` Joel Brobecker
2009-12-02 19:37 ` Paul Pluzhnikov [this message]
2009-12-03 17:48 ` Paul Pluzhnikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ac60eac0912021137u451d942h39a3594e6502bbdb@mail.gmail.com \
--to=ppluzhnikov@google.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox