From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29628 invoked by alias); 2 Dec 2009 19:37:24 -0000 Received: (qmail 29619 invoked by uid 22791); 2 Dec 2009 19:37:24 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.45.13) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 02 Dec 2009 19:37:14 +0000 Received: from zps35.corp.google.com (zps35.corp.google.com [172.25.146.35]) by smtp-out.google.com with ESMTP id nB2JbCmJ014084 for ; Wed, 2 Dec 2009 11:37:12 -0800 Received: from pzk31 (pzk31.prod.google.com [10.243.19.159]) by zps35.corp.google.com with ESMTP id nB2JZfn8005125 for ; Wed, 2 Dec 2009 11:37:10 -0800 Received: by pzk31 with SMTP id 31so407771pzk.28 for ; Wed, 02 Dec 2009 11:37:09 -0800 (PST) MIME-Version: 1.0 Received: by 10.115.98.40 with SMTP id a40mr1057422wam.97.1259782628938; Wed, 02 Dec 2009 11:37:08 -0800 (PST) In-Reply-To: <20091126212111.GB18125@adacore.com> References: <20091125234600.8128276D99@ppluzhnikov.mtv.corp.google.com> <20091126212111.GB18125@adacore.com> Date: Wed, 02 Dec 2009 19:37:00 -0000 Message-ID: <8ac60eac0912021137u451d942h39a3594e6502bbdb@mail.gmail.com> Subject: Re: [patch] Fix for PR gdb/11022 From: Paul Pluzhnikov To: Joel Brobecker Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-12/txt/msg00019.txt.bz2 On Thu, Nov 26, 2009 at 1:21 PM, Joel Brobecker wrote: >> PR gdb/11022 >> >> * breakpoint.c (invalidate_bp_value_on_memory_change): >> New function. >> (_initialize_breakpoint): Add it as memory change observer. > > Seems fine to me, but I have become more and more unfamiliar with > this area, not having been involved with it for a while. So let's wait > a week or so to see if anyone has any comment, and then it can go in. I'll commit this later today, if there are no other comments. >> + j = 0; // break here > Can you use C-style comments, here (since this is a C file)? With the C-style comment correction. Thanks, -- Paul Pluzhnikov