Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Paul Pluzhnikov <ppluzhnikov@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Fix for PR gdb/11022
Date: Thu, 26 Nov 2009 21:21:00 -0000	[thread overview]
Message-ID: <20091126212111.GB18125@adacore.com> (raw)
In-Reply-To: <20091125234600.8128276D99@ppluzhnikov.mtv.corp.google.com>

> 2009-11-25  Paul Pluzhnikov  <ppluzhnikov@google.com>
> 
> 	PR gdb/11022
> 
> 	* breakpoint.c (invalidate_bp_value_on_memory_change):
> 	New function.
> 	(_initialize_breakpoint): Add it as memory change observer.

Seems fine to me, but I have become more and more unfamiliar with
this area, not having been involved with it for a while. So let's wait
a week or so to see if anyone has any comment, and then it can go in.

> 2009-11-25  Paul Pluzhnikov  <ppluzhnikov@google.com>
> 
> 	PR gdb/11022
> 
> 	* gdb.base/pr11022.exp: New test.
> 	* gdb.base/pr11022.c: New test.

Just one tiny comment:

> +    j = 0;  // break here
> +    x = 42;
> +    j = i;  // expect HW watchpoint stop

Can you use C-style comments, here (since this is a C file)?
GCC accepts them even in C, but other C compilers might not.

Thank you,
-- 
Joel


  reply	other threads:[~2009-11-26 21:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-25 23:46 Paul Pluzhnikov
2009-11-26 21:21 ` Joel Brobecker [this message]
2009-12-02 19:37   ` Paul Pluzhnikov
2009-12-03 17:48     ` Paul Pluzhnikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091126212111.GB18125@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=ppluzhnikov@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox