From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14467 invoked by alias); 26 Nov 2009 21:21:21 -0000 Received: (qmail 14457 invoked by uid 22791); 26 Nov 2009 21:21:21 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 26 Nov 2009 21:21:15 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id BDDCE2BABF2; Thu, 26 Nov 2009 16:21:13 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id yrrvifW0+C9i; Thu, 26 Nov 2009 16:21:13 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 876152BAB32; Thu, 26 Nov 2009 16:21:13 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 68249F5905; Thu, 26 Nov 2009 13:21:11 -0800 (PST) Date: Thu, 26 Nov 2009 21:21:00 -0000 From: Joel Brobecker To: Paul Pluzhnikov Cc: gdb-patches@sourceware.org Subject: Re: [patch] Fix for PR gdb/11022 Message-ID: <20091126212111.GB18125@adacore.com> References: <20091125234600.8128276D99@ppluzhnikov.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091125234600.8128276D99@ppluzhnikov.mtv.corp.google.com> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-11/txt/msg00571.txt.bz2 > 2009-11-25 Paul Pluzhnikov > > PR gdb/11022 > > * breakpoint.c (invalidate_bp_value_on_memory_change): > New function. > (_initialize_breakpoint): Add it as memory change observer. Seems fine to me, but I have become more and more unfamiliar with this area, not having been involved with it for a while. So let's wait a week or so to see if anyone has any comment, and then it can go in. > 2009-11-25 Paul Pluzhnikov > > PR gdb/11022 > > * gdb.base/pr11022.exp: New test. > * gdb.base/pr11022.c: New test. Just one tiny comment: > + j = 0; // break here > + x = 42; > + j = i; // expect HW watchpoint stop Can you use C-style comments, here (since this is a C file)? GCC accepts them even in C, but other C compilers might not. Thank you, -- Joel