Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Paul Pluzhnikov <ppluzhnikov@google.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: --gc-section leftovers workaround.
Date: Wed, 28 Oct 2009 21:21:00 -0000	[thread overview]
Message-ID: <8ac60eac0910281421l5dbf1c58o7721dcbd44f14254@mail.gmail.com> (raw)
In-Reply-To: <200910282055.33395.pedro@codesourcery.com>

On Wed, Oct 28, 2009 at 1:55 PM, Pedro Alves <pedro@codesourcery.com> wrote:

> Does gold also not zero out FDE->address_range?

Correct (AFAICT).

> I don't mind at all.  Do you want to propose the wording / a patch?

Something like this, perhaps?

      /* Check for FDEs with zero initial_location.

         Such FDEs could come about when linker discards a section (either
         a COMDAT section when the linker selects a different section
         from the same group, or just a regular section discarded due
         to --gc-sections), but keeps the corresponding .debug_info.

	 The linker sets the relevant FDE.initial_location to zero, but
	 doesn't zero the FDE.address_range because there's no relocation
	 there.  It's (offset, length), not (start, end).

... rest as before ...

Thanks,
-- 
Paul Pluzhnikov


  reply	other threads:[~2009-10-28 21:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-28 18:50 Pedro Alves
2009-10-28 19:23 ` Paul Pluzhnikov
2009-10-28 19:35   ` Pedro Alves
2009-10-28 20:13     ` Paul Pluzhnikov
2009-10-28 20:20       ` Pedro Alves
2009-10-28 20:35         ` Paul Pluzhnikov
2009-10-28 20:55           ` Pedro Alves
2009-10-28 21:21             ` Paul Pluzhnikov [this message]
2009-10-28 19:29 ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8ac60eac0910281421l5dbf1c58o7721dcbd44f14254@mail.gmail.com \
    --to=ppluzhnikov@google.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox