From: Paul Pluzhnikov <ppluzhnikov@google.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: --gc-section leftovers workaround.
Date: Wed, 28 Oct 2009 20:13:00 -0000 [thread overview]
Message-ID: <8ac60eac0910281313h565898fvc3dcdc11728bbbec@mail.gmail.com> (raw)
In-Reply-To: <200910281935.26781.pedro@codesourcery.com>
On Wed, Oct 28, 2009 at 12:35 PM, Pedro Alves <pedro@codesourcery.com> wrote:
>> The patch looks good to me.
>
> It wasn't unfortunately. :-( I had posted an early patch
> that got one thing wrong. It compared FDE->initial_location to
> (FDE+1)->initial_location, to check for overlap, and discarded
> FDE if so. But, this isn't correct since FDE may be the valid one
> we should keep, and (FDE+1)->initial_location could be 0!
Since we've just sorted them, (FDE+1)->initial_location == 0 implies that
FDE->initial_location == 0 as well, doesn't it?
--
Paul Pluzhnikov
next prev parent reply other threads:[~2009-10-28 20:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-28 18:50 Pedro Alves
2009-10-28 19:23 ` Paul Pluzhnikov
2009-10-28 19:35 ` Pedro Alves
2009-10-28 20:13 ` Paul Pluzhnikov [this message]
2009-10-28 20:20 ` Pedro Alves
2009-10-28 20:35 ` Paul Pluzhnikov
2009-10-28 20:55 ` Pedro Alves
2009-10-28 21:21 ` Paul Pluzhnikov
2009-10-28 19:29 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ac60eac0910281313h565898fvc3dcdc11728bbbec@mail.gmail.com \
--to=ppluzhnikov@google.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox