From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23000 invoked by alias); 28 Oct 2009 21:21:18 -0000 Received: (qmail 22992 invoked by uid 22791); 28 Oct 2009 21:21:17 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.45.13) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 28 Oct 2009 21:21:13 +0000 Received: from zps76.corp.google.com (zps76.corp.google.com [172.25.146.76]) by smtp-out.google.com with ESMTP id n9SLLBXn026619 for ; Wed, 28 Oct 2009 14:21:11 -0700 Received: from pxi7 (pxi7.prod.google.com [10.243.27.7]) by zps76.corp.google.com with ESMTP id n9SLL9kN023824 for ; Wed, 28 Oct 2009 14:21:09 -0700 Received: by pxi7 with SMTP id 7so858006pxi.17 for ; Wed, 28 Oct 2009 14:21:09 -0700 (PDT) MIME-Version: 1.0 Received: by 10.114.214.28 with SMTP id m28mr10151364wag.44.1256764869025; Wed, 28 Oct 2009 14:21:09 -0700 (PDT) In-Reply-To: <200910282055.33395.pedro@codesourcery.com> References: <200910281851.01364.pedro@codesourcery.com> <200910282020.48879.pedro@codesourcery.com> <8ac60eac0910281335l959c202u3c137255abdb0a00@mail.gmail.com> <200910282055.33395.pedro@codesourcery.com> Date: Wed, 28 Oct 2009 21:21:00 -0000 Message-ID: <8ac60eac0910281421l5dbf1c58o7721dcbd44f14254@mail.gmail.com> Subject: Re: --gc-section leftovers workaround. From: Paul Pluzhnikov To: Pedro Alves Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-10/txt/msg00683.txt.bz2 On Wed, Oct 28, 2009 at 1:55 PM, Pedro Alves wrote: > Does gold also not zero out FDE->address_range? Correct (AFAICT). > I don't mind at all. =A0Do you want to propose the wording / a patch? Something like this, perhaps? /* Check for FDEs with zero initial_location. Such FDEs could come about when linker discards a section (either a COMDAT section when the linker selects a different section from the same group, or just a regular section discarded due to --gc-sections), but keeps the corresponding .debug_info. The linker sets the relevant FDE.initial_location to zero, but doesn't zero the FDE.address_range because there's no relocation there. It's (offset, length), not (start, end). ... rest as before ... Thanks, --=20 Paul Pluzhnikov