Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simark@simark.ca>
To: Kevin Buettner <kevinb@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/4] gdb/elfread: add debug output for GNU ifunc resolution
Date: Fri, 13 Feb 2026 14:10:10 -0500	[thread overview]
Message-ID: <8980b3ba-e2cd-43de-b1e0-01f1a2bcc7ab@simark.ca> (raw)
In-Reply-To: <20260213112708.38821e69@f42-zbm-amd>



On 2026-02-13 13:27, Kevin Buettner wrote:
> On Fri, 13 Feb 2026 00:38:48 -0500
> simon.marchi@polymtl.ca wrote:
> 
>> From: Simon Marchi <simon.marchi@polymtl.ca>
>>
>> Add some debug prints throughout the ifunc resolution code, to be able
>> to better understand what GDB does.  Add the new "set debug gnu-ifunc"
>> knob to control it.
>>
>> Add the debug_prefixed_printf_cond_func macro to implement
>> gnu_ifunc_debug_printf_func, that takes an explicit function name.  This
>> is needed to avoid showing "operator()" as the function name in the
>> debug message.
>>
>> Here is a sample session with the new debug output enabled.
>>
> [...]
>> ---
>>  gdb/NEWS                  |   4 ++
>>  gdb/doc/gdb.texinfo       |   6 +++
>>  gdb/elfread.c             | 110 +++++++++++++++++++++++++++++++++++---
>>  gdbsupport/common-debug.h |   9 ++++
>>  4 files changed, 123 insertions(+), 6 deletions(-)
> 
> This would have been helpful when I was debugging some ifunc related
> problems last year.

Glad to know that, I hope it will be useful in the future.

> I've looked over all four parts.  They all LGTM.
> 
> Approved-by: Kevin Buettner <kevinb@redhat.com>

Thanks, I pushed the series.  I can work on Eli's request to clarify
ifunc in the doc as a separate patch.

Simon

      reply	other threads:[~2026-02-13 19:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-13  5:38 simon.marchi
2026-02-13  5:38 ` [PATCH 2/4] gdb/elfread: replace ifunc htab_t with gdb::unordered_map simon.marchi
2026-02-13  5:38 ` [PATCH 3/4] gdbsupport: add gdb::unordered_string_map simon.marchi
2026-02-13  5:38 ` [PATCH 4/4] gdb: use gdb::unordered_string_map throughout simon.marchi
2026-02-13  8:30 ` [PATCH 1/4] gdb/elfread: add debug output for GNU ifunc resolution Eli Zaretskii
2026-02-13 17:20   ` Simon Marchi
2026-02-13 18:27 ` Kevin Buettner
2026-02-13 19:10   ` Simon Marchi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8980b3ba-e2cd-43de-b1e0-01f1a2bcc7ab@simark.ca \
    --to=simark@simark.ca \
    --cc=gdb-patches@sourceware.org \
    --cc=kevinb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox