From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 7/6nLy93j2ndnjkAWB0awg (envelope-from ) for ; Fri, 13 Feb 2026 14:10:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1771009839; bh=3P0YTAq4GWuSCKqXMov33kDPAUfoYbHL4Le6CUSYWgw=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=ezxYaZGbAjmiDGNLd99WiDyr3c4PeTjfRHPAmLIZyYDdtjfLFFswhwzGAQ/faYFuz hXPboIEaOuwk4mqlff/FOKFHELtvghxjx2CelNrW2Ag+HloElMUDrpp8K9mHA+NzBl XM7pY1TvXR0gJMyO9ITdWpHh5pgINgYFYCDilEKk= Received: by simark.ca (Postfix, from userid 112) id ACB9A1E08D; Fri, 13 Feb 2026 14:10:39 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=BzayoVQm; dkim-atps=neutral Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 363621E08D for ; Fri, 13 Feb 2026 14:10:39 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 00CFD4B9DB66 for ; Fri, 13 Feb 2026 19:10:38 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 00CFD4B9DB66 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=BzayoVQm Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 823CA4B9DB49 for ; Fri, 13 Feb 2026 19:10:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 823CA4B9DB49 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 823CA4B9DB49 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1771009812; cv=none; b=H+bYwBSTT0qvCa65g2+pxFY1YggJY0NUTcrCMOB+Sbn60C2eARITlqEymEpmGoljzfRovfsKU22+yp9iROdfNF3KDdBmuWgblMXHc+R+beqrc/s7c7HSkgii+uihhdabl+t+lyqDnC1fW3Ucj9HZSy3haZdN29z9vztXEhHR5fM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1771009812; c=relaxed/simple; bh=3P0YTAq4GWuSCKqXMov33kDPAUfoYbHL4Le6CUSYWgw=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=oVZTZL1cDB6lZZpzkYPkK93s8M2qdqIvmoIPZYDGZG6LYBSRWD/PDp1ytQELc0vJziyEnvObgxHtIpqFHsWMKLQW6dhw9meVznqKVryCWSZ6H5NAohMCSak0ig5NGWphUxmCx4rb872CgQvYIoCSG90uYFVVkI2D5k71BZ/7X/s= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 823CA4B9DB49 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1771009810; bh=3P0YTAq4GWuSCKqXMov33kDPAUfoYbHL4Le6CUSYWgw=; h=Date:Subject:To:References:From:In-Reply-To:From; b=BzayoVQmPFJ2RJCE0w7zqGgViCcZ9DiUr1m5y5DJvZKYfOSYfETOoH5spJTaxrBl+ 2OoKH8WyMqBRCLrR+nVQAXXRIUiV+UtIs0K23vFoArYyfLoqjn5DEiTDv7p/l14cNG TQ9X8DB5u+5mkuG7h7yUZ2PoRkVq8rAKhOvEgqzU= Received: by simark.ca (Postfix) id 9D6021E08D; Fri, 13 Feb 2026 14:10:10 -0500 (EST) Message-ID: <8980b3ba-e2cd-43de-b1e0-01f1a2bcc7ab@simark.ca> Date: Fri, 13 Feb 2026 14:10:10 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] gdb/elfread: add debug output for GNU ifunc resolution To: Kevin Buettner , gdb-patches@sourceware.org References: <20260213053912.3520505-1-simon.marchi@polymtl.ca> <20260213112708.38821e69@f42-zbm-amd> Content-Language: en-US From: Simon Marchi In-Reply-To: <20260213112708.38821e69@f42-zbm-amd> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2026-02-13 13:27, Kevin Buettner wrote: > On Fri, 13 Feb 2026 00:38:48 -0500 > simon.marchi@polymtl.ca wrote: > >> From: Simon Marchi >> >> Add some debug prints throughout the ifunc resolution code, to be able >> to better understand what GDB does. Add the new "set debug gnu-ifunc" >> knob to control it. >> >> Add the debug_prefixed_printf_cond_func macro to implement >> gnu_ifunc_debug_printf_func, that takes an explicit function name. This >> is needed to avoid showing "operator()" as the function name in the >> debug message. >> >> Here is a sample session with the new debug output enabled. >> > [...] >> --- >> gdb/NEWS | 4 ++ >> gdb/doc/gdb.texinfo | 6 +++ >> gdb/elfread.c | 110 +++++++++++++++++++++++++++++++++++--- >> gdbsupport/common-debug.h | 9 ++++ >> 4 files changed, 123 insertions(+), 6 deletions(-) > > This would have been helpful when I was debugging some ifunc related > problems last year. Glad to know that, I hope it will be useful in the future. > I've looked over all four parts. They all LGTM. > > Approved-by: Kevin Buettner Thanks, I pushed the series. I can work on Eli's request to clarify ifunc in the doc as a separate patch. Simon