Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: simon.marchi@polymtl.ca
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/4] gdb/elfread: add debug output for GNU ifunc resolution
Date: Fri, 13 Feb 2026 10:30:27 +0200	[thread overview]
Message-ID: <86v7g1qc4c.fsf@gnu.org> (raw)
In-Reply-To: <20260213053912.3520505-1-simon.marchi@polymtl.ca>

> From: simon.marchi@polymtl.ca
> Cc: Simon Marchi <simon.marchi@polymtl.ca>
> Date: Fri, 13 Feb 2026 00:38:48 -0500
> 
> ---
>  gdb/NEWS                  |   4 ++
>  gdb/doc/gdb.texinfo       |   6 +++
>  gdb/elfread.c             | 110 +++++++++++++++++++++++++++++++++++---
>  gdbsupport/common-debug.h |   9 ++++
>  4 files changed, 123 insertions(+), 6 deletions(-)

Thanks.  The documentation parts are okay, but I would suggest to say
in the manual a few words about what are "GNU ifunc" thingies, because
otherwise the documentation is not clear enough to the reader.

Reviewed-By: Eli Zaretskii <eliz@gnu.org>

  parent reply	other threads:[~2026-02-13  8:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-13  5:38 simon.marchi
2026-02-13  5:38 ` [PATCH 2/4] gdb/elfread: replace ifunc htab_t with gdb::unordered_map simon.marchi
2026-02-13  5:38 ` [PATCH 3/4] gdbsupport: add gdb::unordered_string_map simon.marchi
2026-02-13  5:38 ` [PATCH 4/4] gdb: use gdb::unordered_string_map throughout simon.marchi
2026-02-13  8:30 ` Eli Zaretskii [this message]
2026-02-13 17:20   ` [PATCH 1/4] gdb/elfread: add debug output for GNU ifunc resolution Simon Marchi
2026-02-13 18:27 ` Kevin Buettner
2026-02-13 19:10   ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86v7g1qc4c.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@polymtl.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox