From: Bruno Larsen via Gdb-patches <gdb-patches@sourceware.org>
To: Andrew Burgess <aburgess@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v4 09/15] gdb/testsuite: fix gdb.base/msym-bp-shl when running with Clang
Date: Mon, 12 Sep 2022 14:30:49 +0200 [thread overview]
Message-ID: <88490ee2-085f-ed2e-aa1c-f04b71557ce7@redhat.com> (raw)
In-Reply-To: <87h71cluzk.fsf@redhat.com>
On 12/09/2022 12:58, Andrew Burgess wrote:
> Bruno Larsen via Gdb-patches <gdb-patches@sourceware.org> writes:
>
>> Because Clang's -O0 is not as unoptimized as gcc's, one of the functions
>> of gdb.base/msym-bp-shl was being optimized away, making the entire test
>> fail. A lot of the test fail like so:
>>
>> (gdb) break foo
>> Breakpoint 1 at 0x401030
>> (gdb) FAIL: gdb.base/msym-bp-shl.exp: debug=0: before run: break foo
>> info breakpoint
>> Num Type Disp Enb Address What
>> 1 breakpoint keep y 0x0000000000401030 <foo@plt>
>> (gdb) FAIL: gdb.base/msym-bp-shl.exp: debug=0: before run: info breakpoint
>>
>> As the test expects 2 breakpoints to be placed. This can't be easily fixed
>> by adding __attribute__ ((used)) to the function, since Clang will still
>> optimize away the function. Because of this, the test is skipped when
>> the it detects that Clang is being used
> In this mail:
>
> https://sourceware.org/pipermail/gdb-patches/2022-March/187197.html
>
> Pedro suggests using __attribute__((used)), in your follow up:
>
> https://sourceware.org/pipermail/gdb-patches/2022-March/187199.html
>
> you confirm that this approach works for you. I just checked, and the
> attribute patch Pedro suggests makes the test pass for me with Clang.
>
> Should this patch have been updated? If not, what changed?
This patch should have been updated, sorry.
--
Cheers,
Bruno
>
> Thanks,
> Andrew
>
>> ---
>> gdb/testsuite/gdb.base/msym-bp-shl.exp | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/gdb/testsuite/gdb.base/msym-bp-shl.exp b/gdb/testsuite/gdb.base/msym-bp-shl.exp
>> index 42adcb191dd..dd7d05bab52 100644
>> --- a/gdb/testsuite/gdb.base/msym-bp-shl.exp
>> +++ b/gdb/testsuite/gdb.base/msym-bp-shl.exp
>> @@ -22,6 +22,14 @@ if {[skip_shlib_tests]} {
>> return 0
>> }
>>
>> +# Clang will optimize away the static foo, regardless of using
>> +# __attribute__((used)), so we'll always get a single breakpoint
>> +# making this test useless
>> +if {[test_compiler_info {clang-*-*}]} {
>> + untested "Clang optimizes away one of the functions"
>> + return
>> +}
>> +
>> standard_testfile msym-bp-shl-main.c msym-bp-shl-main-2.c msym-bp-shl-lib.c
>> set srcfile ${srcdir}/${subdir}/${srcfile}
>> set srcfile2 ${srcdir}/${subdir}/${srcfile2}
>> --
>> 2.31.1
next prev parent reply other threads:[~2022-09-12 12:31 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-20 19:44 [PATCH v4 00/15] Clean gdb.base when testing with clang Bruno Larsen via Gdb-patches
2022-07-20 19:44 ` [PATCH v4 01/15] gdb/testsuite: introduce gdb_step_until Bruno Larsen via Gdb-patches
2022-07-20 19:44 ` [PATCH v4 01/15] gdb/testsuite: introduce gdb_step_until_regexp Bruno Larsen via Gdb-patches
2022-07-20 19:44 ` [PATCH v4 02/15] gdb/testsuite: Add a proc to test where compiler links the epilogue Bruno Larsen via Gdb-patches
2022-09-13 12:17 ` Andrew Burgess via Gdb-patches
2022-07-20 19:44 ` [PATCH v4 03/15] Change gdb.base/skip-solib.exp deal with lack of epilogue information Bruno Larsen via Gdb-patches
2022-09-10 9:53 ` Andrew Burgess via Gdb-patches
2022-07-20 19:44 ` [PATCH v4 04/15] gdb/testsuite: change gdb.base/nodebug.exp to not fail with clang Bruno Larsen via Gdb-patches
2022-09-12 9:08 ` Andrew Burgess via Gdb-patches
2022-09-12 12:17 ` Bruno Larsen via Gdb-patches
2022-07-20 19:44 ` [PATCH v4 05/15] update gdb.base/info-program.exp " Bruno Larsen via Gdb-patches
2022-09-12 9:34 ` Andrew Burgess via Gdb-patches
2022-09-12 12:18 ` Bruno Larsen via Gdb-patches
2022-07-20 19:44 ` [PATCH v4 06/15] fix gdb.base/access-mem-running.exp for clang testing Bruno Larsen via Gdb-patches
2022-09-12 9:41 ` Andrew Burgess via Gdb-patches
2022-09-12 12:18 ` Bruno Larsen via Gdb-patches
2022-07-20 19:44 ` [PATCH v4 07/15] Fix gdb.base/call-ar-st to work with Clang Bruno Larsen via Gdb-patches
2022-09-12 10:30 ` Andrew Burgess via Gdb-patches
2022-09-12 12:18 ` Bruno Larsen via Gdb-patches
2022-07-20 19:44 ` [PATCH v4 08/15] add xfails to gdb.base/complex-parts.exp when testing with clang Bruno Larsen via Gdb-patches
2022-09-12 10:49 ` Andrew Burgess via Gdb-patches
2022-09-12 12:18 ` Bruno Larsen via Gdb-patches
2022-07-20 19:44 ` [PATCH v4 09/15] gdb/testsuite: fix gdb.base/msym-bp-shl when running with Clang Bruno Larsen via Gdb-patches
2022-09-12 10:58 ` Andrew Burgess via Gdb-patches
2022-09-12 12:30 ` Bruno Larsen via Gdb-patches [this message]
2022-07-20 19:44 ` [PATCH v4 10/15] explicitly test for stderr in gdb.base/dprintf.exp Bruno Larsen via Gdb-patches
2022-09-12 12:20 ` Andrew Burgess via Gdb-patches
2022-09-13 12:08 ` Bruno Larsen via Gdb-patches
2022-07-20 19:44 ` [PATCH v4 11/15] gdb/testsuite: Update gdb.base/so-impl-ld.exp Bruno Larsen via Gdb-patches
2022-09-12 12:30 ` Andrew Burgess via Gdb-patches
2022-09-13 12:08 ` Bruno Larsen via Gdb-patches
2022-07-20 19:44 ` [PATCH v4 12/15] [gdb/testsuite]: fix gdb.base/jit-elf.exp when testing with clang Bruno Larsen via Gdb-patches
2022-09-12 12:54 ` Andrew Burgess via Gdb-patches
2022-07-20 19:44 ` [PATCH v4 13/15] gdb/testsuite: fix gdb.base/info-types-c++ " Bruno Larsen via Gdb-patches
2022-09-12 14:35 ` Andrew Burgess via Gdb-patches
2022-09-14 11:31 ` Bruno Larsen via Gdb-patches
2022-07-20 19:44 ` [PATCH v4 14/15] gdb.base/skip.exp: Use finish to exit functions Bruno Larsen via Gdb-patches
2022-09-12 16:57 ` Andrew Burgess via Gdb-patches
2022-07-20 19:44 ` [PATCH v4 15/15] gdb/testsuite: Add test to step through function epilogue Bruno Larsen via Gdb-patches
2022-09-08 12:04 ` Andrew Burgess via Gdb-patches
2022-08-09 16:53 ` [PIING][PATCH v4 00/15] Clean gdb.base when testing with clang Bruno Larsen via Gdb-patches
2022-08-18 7:25 ` [PINGv2][PATCH " Bruno Larsen via Gdb-patches
2022-08-25 7:51 ` [PINGv3][PATCH " Bruno Larsen via Gdb-patches
2022-09-05 14:59 ` [PINGv4][PATCH " Bruno Larsen via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88490ee2-085f-ed2e-aa1c-f04b71557ce7@redhat.com \
--to=gdb-patches@sourceware.org \
--cc=aburgess@redhat.com \
--cc=blarsen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox