From: Bruno Larsen via Gdb-patches <gdb-patches@sourceware.org>
To: Andrew Burgess <aburgess@redhat.com>, gdb-patches@sourceware.org
Cc: Pedro Alves <pedro@palves.net>
Subject: Re: [PATCH v4 07/15] Fix gdb.base/call-ar-st to work with Clang
Date: Mon, 12 Sep 2022 14:18:03 +0200 [thread overview]
Message-ID: <2270bf07-cbee-dfba-91ca-47f79e47b85d@redhat.com> (raw)
In-Reply-To: <87mtb4lwb7.fsf@redhat.com>
thanks, pushed!
Cheers,
Bruno
On 12/09/2022 12:30, Andrew Burgess wrote:
> Bruno Larsen via Gdb-patches <gdb-patches@sourceware.org> writes:
>
>> When running gdb.base/call-ar-st.exp against Clang, we see one FAIL,
>> like so:
>>
>> print_all_arrays (array_i=<main.integer_array>, array_c=<main.char_array> "ZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZa
>> ZaZaZaZaZaZaZaZaZaZaZaZa", array_f=<main.float_array>, array_d=<main.double_array>) at ../../../src/gdb/testsuite/gdb.base/call-ar-st.c:274
>> 274 print_int_array(array_i); /* -step1- */
>> (gdb) FAIL: gdb.base/call-ar-st.exp: step inside print_all_arrays
>>
>> With GCC we instead see:
>>
>> print_all_arrays (array_i=<integer_array>, array_c=<char_array> "ZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZa", array_f=<float_array>, array_d=<double_array>) at /home/pedro/gdb/build/gdb/testsuite/../../../src/gdb/testsuite/gdb.base/call-ar-st.c:274
>> 274 print_int_array(array_i); /* -step1- */
>> (gdb) PASS: gdb.base/call-ar-st.exp: step inside print_all_arrays
>>
>> The difference is that with Clang we get:
>>
>> array_i=<main.integer_array>, ...
>>
>> instead of
>>
>> array_i = <integer_array>, ...
>>
>> These symbols are local static variables, and "main" is the name of
>> the function they are defined in. GCC instead appends a sequence
>> number to the linkage name:
>>
>> $ nm -A call-ar-st.gcc | grep integer_
>> call-ar-st/call-ar-st:00000000000061a0 b integer_array.3968
>>
>> $ nm -A call-ar-st.clang | grep integer_
>> call-ar-st:00000000004061a0 b main.integer_array
>>
>> This commit changes the testcase to accept both outputs, as they are
>> functionally identical.
>>
>> Co-Authored-By: Pedro Alves <pedro@palves.net>
>> Change-Id: Iaf2ccdb9d5996e0268ed12f595a6e04b368bfcb4
> LGTM. I think this could be merged.
>
> Thanks,
> Andrew
>
>
>> ---
>> gdb/testsuite/gdb.base/call-ar-st.exp | 13 ++++++++++++-
>> 1 file changed, 12 insertions(+), 1 deletion(-)
>>
>> diff --git a/gdb/testsuite/gdb.base/call-ar-st.exp b/gdb/testsuite/gdb.base/call-ar-st.exp
>> index 7c80ec7c0b8..2da438ccd96 100644
>> --- a/gdb/testsuite/gdb.base/call-ar-st.exp
>> +++ b/gdb/testsuite/gdb.base/call-ar-st.exp
>> @@ -147,10 +147,21 @@ if {!$skip_float_test && \
>> gdb_test "continue" ".*" ""
>> }
>>
>> +# Return a regexp that matches the linkage name of SYM, assuming SYM
>> +# is a local static variable inside the main function.
>> +proc main_static_local_re {sym} {
>> + # Clang prepends the function name + '.'.
>> + return "(main\\.)?${sym}"
>> +}
>> +
>> #step
>> set stop_line [gdb_get_line_number "-step1-"]
>> gdb_test "step" \
>> - "print_all_arrays \\(array_i=<integer_array.*>, array_c=<char_array.*> .ZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZa., array_f=<float_array.*>, array_d=<double_array.*>\\) at .*$srcfile:$stop_line\[ \t\r\n\]+$stop_line.*print_int_array\\(array_i\\);.*" \
>> + "print_all_arrays \\(array_i=<[main_static_local_re integer_array]>,\
>> + array_c=<[main_static_local_re char_array]> .ZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZaZa.,\
>> + array_f=<[main_static_local_re float_array]>,\
>> + array_d=<[main_static_local_re double_array]>\\)\
>> + at .*$srcfile:$stop_line\[ \t\r\n\]+$stop_line.*print_int_array\\(array_i\\);.*" \
>> "step inside print_all_arrays"
>>
>> #step -over
>> --
>> 2.31.1
next prev parent reply other threads:[~2022-09-12 12:18 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-20 19:44 [PATCH v4 00/15] Clean gdb.base when testing with clang Bruno Larsen via Gdb-patches
2022-07-20 19:44 ` [PATCH v4 01/15] gdb/testsuite: introduce gdb_step_until Bruno Larsen via Gdb-patches
2022-07-20 19:44 ` [PATCH v4 01/15] gdb/testsuite: introduce gdb_step_until_regexp Bruno Larsen via Gdb-patches
2022-07-20 19:44 ` [PATCH v4 02/15] gdb/testsuite: Add a proc to test where compiler links the epilogue Bruno Larsen via Gdb-patches
2022-09-13 12:17 ` Andrew Burgess via Gdb-patches
2022-07-20 19:44 ` [PATCH v4 03/15] Change gdb.base/skip-solib.exp deal with lack of epilogue information Bruno Larsen via Gdb-patches
2022-09-10 9:53 ` Andrew Burgess via Gdb-patches
2022-07-20 19:44 ` [PATCH v4 04/15] gdb/testsuite: change gdb.base/nodebug.exp to not fail with clang Bruno Larsen via Gdb-patches
2022-09-12 9:08 ` Andrew Burgess via Gdb-patches
2022-09-12 12:17 ` Bruno Larsen via Gdb-patches
2022-07-20 19:44 ` [PATCH v4 05/15] update gdb.base/info-program.exp " Bruno Larsen via Gdb-patches
2022-09-12 9:34 ` Andrew Burgess via Gdb-patches
2022-09-12 12:18 ` Bruno Larsen via Gdb-patches
2022-07-20 19:44 ` [PATCH v4 06/15] fix gdb.base/access-mem-running.exp for clang testing Bruno Larsen via Gdb-patches
2022-09-12 9:41 ` Andrew Burgess via Gdb-patches
2022-09-12 12:18 ` Bruno Larsen via Gdb-patches
2022-07-20 19:44 ` [PATCH v4 07/15] Fix gdb.base/call-ar-st to work with Clang Bruno Larsen via Gdb-patches
2022-09-12 10:30 ` Andrew Burgess via Gdb-patches
2022-09-12 12:18 ` Bruno Larsen via Gdb-patches [this message]
2022-07-20 19:44 ` [PATCH v4 08/15] add xfails to gdb.base/complex-parts.exp when testing with clang Bruno Larsen via Gdb-patches
2022-09-12 10:49 ` Andrew Burgess via Gdb-patches
2022-09-12 12:18 ` Bruno Larsen via Gdb-patches
2022-07-20 19:44 ` [PATCH v4 09/15] gdb/testsuite: fix gdb.base/msym-bp-shl when running with Clang Bruno Larsen via Gdb-patches
2022-09-12 10:58 ` Andrew Burgess via Gdb-patches
2022-09-12 12:30 ` Bruno Larsen via Gdb-patches
2022-07-20 19:44 ` [PATCH v4 10/15] explicitly test for stderr in gdb.base/dprintf.exp Bruno Larsen via Gdb-patches
2022-09-12 12:20 ` Andrew Burgess via Gdb-patches
2022-09-13 12:08 ` Bruno Larsen via Gdb-patches
2022-07-20 19:44 ` [PATCH v4 11/15] gdb/testsuite: Update gdb.base/so-impl-ld.exp Bruno Larsen via Gdb-patches
2022-09-12 12:30 ` Andrew Burgess via Gdb-patches
2022-09-13 12:08 ` Bruno Larsen via Gdb-patches
2022-07-20 19:44 ` [PATCH v4 12/15] [gdb/testsuite]: fix gdb.base/jit-elf.exp when testing with clang Bruno Larsen via Gdb-patches
2022-09-12 12:54 ` Andrew Burgess via Gdb-patches
2022-07-20 19:44 ` [PATCH v4 13/15] gdb/testsuite: fix gdb.base/info-types-c++ " Bruno Larsen via Gdb-patches
2022-09-12 14:35 ` Andrew Burgess via Gdb-patches
2022-09-14 11:31 ` Bruno Larsen via Gdb-patches
2022-07-20 19:44 ` [PATCH v4 14/15] gdb.base/skip.exp: Use finish to exit functions Bruno Larsen via Gdb-patches
2022-09-12 16:57 ` Andrew Burgess via Gdb-patches
2022-07-20 19:44 ` [PATCH v4 15/15] gdb/testsuite: Add test to step through function epilogue Bruno Larsen via Gdb-patches
2022-09-08 12:04 ` Andrew Burgess via Gdb-patches
2022-08-09 16:53 ` [PIING][PATCH v4 00/15] Clean gdb.base when testing with clang Bruno Larsen via Gdb-patches
2022-08-18 7:25 ` [PINGv2][PATCH " Bruno Larsen via Gdb-patches
2022-08-25 7:51 ` [PINGv3][PATCH " Bruno Larsen via Gdb-patches
2022-09-05 14:59 ` [PINGv4][PATCH " Bruno Larsen via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2270bf07-cbee-dfba-91ca-47f79e47b85d@redhat.com \
--to=gdb-patches@sourceware.org \
--cc=aburgess@redhat.com \
--cc=blarsen@redhat.com \
--cc=pedro@palves.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox