From: Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org>
To: Bruno Larsen <blarsen@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v4 11/15] gdb/testsuite: Update gdb.base/so-impl-ld.exp
Date: Mon, 12 Sep 2022 13:30:03 +0100 [thread overview]
Message-ID: <87bkrklqr8.fsf@redhat.com> (raw)
In-Reply-To: <20220720194441.168906-13-blarsen@redhat.com>
Bruno Larsen via Gdb-patches <gdb-patches@sourceware.org> writes:
> gdb.base/so-impl-ld.exp was setup assuming that the compiler would add
> epilogue information and that GDB would stop in the } line. This would
> make clang tests fail like so:
>
> step^M
> solib_main (arg=10000) at ../../../common/git-repos/binutils-gdb/gdb/testsuite/gdb.base/solib1.c:7^M
> 7|__ return arg*arg;|__|___/* HERE */^M
> (gdb) PASS: gdb.base/so-impl-ld.exp: step into solib call
> next^M
> main () at ../../../common/git-repos/binutils-gdb/gdb/testsuite/gdb.base/so-impl-ld.c:22^M
> 22|_ return 0;^M
> (gdb) FAIL: gdb.base/so-impl-ld.exp: step in solib call
> next^M
> 0x00007ffff7cef560 in __libc_start_call_main () from /lib64/libc.so.6^M
> (gdb) FAIL: gdb.base/so-impl-ld.exp: step out of solib call
>
> This patch changes it so solib_main has 2 lines where GDB can stop
> regardless of compiler weirdness, and updates the exp file to
s/weirdness/choices/ - I don't think there's necessarily anything
"weird" about Clang's choice, it's just different.
With that change, I think you can push this patch, and the patch that
provides gdb_step_until.
Thanks,
Andrew
> generically deal with unknown number of steps until leaving that
> function.
> ---
> gdb/testsuite/gdb.base/so-impl-ld.exp | 13 ++-----------
> gdb/testsuite/gdb.base/solib1.c | 5 +++--
> 2 files changed, 5 insertions(+), 13 deletions(-)
>
> diff --git a/gdb/testsuite/gdb.base/so-impl-ld.exp b/gdb/testsuite/gdb.base/so-impl-ld.exp
> index 372b18f3915..3c5d1070a5b 100644
> --- a/gdb/testsuite/gdb.base/so-impl-ld.exp
> +++ b/gdb/testsuite/gdb.base/so-impl-ld.exp
> @@ -56,21 +56,12 @@ gdb_test "step" "solib_main .arg=10000. at.*${libfile}.c:${decimal}.* HERE .*" \
>
> # Verify that we can step within the shlib call.
> #
> -gdb_test "next" "${decimal}\[ \t\]*\}.* STEP .*" "step in solib call"
> +gdb_test "next" "${decimal}\[ \t\]*return ans;.* STEP .*" "step in solib call"
>
> # Verify that we can step out of the shlib call, and back out into
> # the caller.
> #
> -gdb_test_multiple "next" "step out of solib call" {
> - -re "0x\[0-9a-f\]*\[ \t\]*9\[ \t\]*.*$gdb_prompt $" {
> - gdb_test "next" \
> - "main .. at.*so-impl-ld.c:22.*" \
> - "step out of solib call"
> - }
> - -re "main .. at.*so-impl-ld.c:22.*$gdb_prompt $" {
> - pass "step out of solib call"
> - }
> -}
> +gdb_step_until ".*main .. at.*return 0;.*" "step out of solib call"
>
> gdb_exit
> return 0
> diff --git a/gdb/testsuite/gdb.base/solib1.c b/gdb/testsuite/gdb.base/solib1.c
> index 16b72338f26..bf52beec5de 100644
> --- a/gdb/testsuite/gdb.base/solib1.c
> +++ b/gdb/testsuite/gdb.base/solib1.c
> @@ -4,5 +4,6 @@ extern "C"
> int
> solib_main (int arg)
> {
> - return arg*arg; /* HERE */
> -} /* STEP */
> + int ans = arg*arg; /* HERE */
> + return ans; /* STEP */
> +}
> --
> 2.31.1
next prev parent reply other threads:[~2022-09-12 12:30 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-20 19:44 [PATCH v4 00/15] Clean gdb.base when testing with clang Bruno Larsen via Gdb-patches
2022-07-20 19:44 ` [PATCH v4 01/15] gdb/testsuite: introduce gdb_step_until Bruno Larsen via Gdb-patches
2022-07-20 19:44 ` [PATCH v4 01/15] gdb/testsuite: introduce gdb_step_until_regexp Bruno Larsen via Gdb-patches
2022-07-20 19:44 ` [PATCH v4 02/15] gdb/testsuite: Add a proc to test where compiler links the epilogue Bruno Larsen via Gdb-patches
2022-09-13 12:17 ` Andrew Burgess via Gdb-patches
2022-07-20 19:44 ` [PATCH v4 03/15] Change gdb.base/skip-solib.exp deal with lack of epilogue information Bruno Larsen via Gdb-patches
2022-09-10 9:53 ` Andrew Burgess via Gdb-patches
2022-07-20 19:44 ` [PATCH v4 04/15] gdb/testsuite: change gdb.base/nodebug.exp to not fail with clang Bruno Larsen via Gdb-patches
2022-09-12 9:08 ` Andrew Burgess via Gdb-patches
2022-09-12 12:17 ` Bruno Larsen via Gdb-patches
2022-07-20 19:44 ` [PATCH v4 05/15] update gdb.base/info-program.exp " Bruno Larsen via Gdb-patches
2022-09-12 9:34 ` Andrew Burgess via Gdb-patches
2022-09-12 12:18 ` Bruno Larsen via Gdb-patches
2022-07-20 19:44 ` [PATCH v4 06/15] fix gdb.base/access-mem-running.exp for clang testing Bruno Larsen via Gdb-patches
2022-09-12 9:41 ` Andrew Burgess via Gdb-patches
2022-09-12 12:18 ` Bruno Larsen via Gdb-patches
2022-07-20 19:44 ` [PATCH v4 07/15] Fix gdb.base/call-ar-st to work with Clang Bruno Larsen via Gdb-patches
2022-09-12 10:30 ` Andrew Burgess via Gdb-patches
2022-09-12 12:18 ` Bruno Larsen via Gdb-patches
2022-07-20 19:44 ` [PATCH v4 08/15] add xfails to gdb.base/complex-parts.exp when testing with clang Bruno Larsen via Gdb-patches
2022-09-12 10:49 ` Andrew Burgess via Gdb-patches
2022-09-12 12:18 ` Bruno Larsen via Gdb-patches
2022-07-20 19:44 ` [PATCH v4 09/15] gdb/testsuite: fix gdb.base/msym-bp-shl when running with Clang Bruno Larsen via Gdb-patches
2022-09-12 10:58 ` Andrew Burgess via Gdb-patches
2022-09-12 12:30 ` Bruno Larsen via Gdb-patches
2022-07-20 19:44 ` [PATCH v4 10/15] explicitly test for stderr in gdb.base/dprintf.exp Bruno Larsen via Gdb-patches
2022-09-12 12:20 ` Andrew Burgess via Gdb-patches
2022-09-13 12:08 ` Bruno Larsen via Gdb-patches
2022-07-20 19:44 ` [PATCH v4 11/15] gdb/testsuite: Update gdb.base/so-impl-ld.exp Bruno Larsen via Gdb-patches
2022-09-12 12:30 ` Andrew Burgess via Gdb-patches [this message]
2022-09-13 12:08 ` Bruno Larsen via Gdb-patches
2022-07-20 19:44 ` [PATCH v4 12/15] [gdb/testsuite]: fix gdb.base/jit-elf.exp when testing with clang Bruno Larsen via Gdb-patches
2022-09-12 12:54 ` Andrew Burgess via Gdb-patches
2022-07-20 19:44 ` [PATCH v4 13/15] gdb/testsuite: fix gdb.base/info-types-c++ " Bruno Larsen via Gdb-patches
2022-09-12 14:35 ` Andrew Burgess via Gdb-patches
2022-09-14 11:31 ` Bruno Larsen via Gdb-patches
2022-07-20 19:44 ` [PATCH v4 14/15] gdb.base/skip.exp: Use finish to exit functions Bruno Larsen via Gdb-patches
2022-09-12 16:57 ` Andrew Burgess via Gdb-patches
2022-07-20 19:44 ` [PATCH v4 15/15] gdb/testsuite: Add test to step through function epilogue Bruno Larsen via Gdb-patches
2022-09-08 12:04 ` Andrew Burgess via Gdb-patches
2022-08-09 16:53 ` [PIING][PATCH v4 00/15] Clean gdb.base when testing with clang Bruno Larsen via Gdb-patches
2022-08-18 7:25 ` [PINGv2][PATCH " Bruno Larsen via Gdb-patches
2022-08-25 7:51 ` [PINGv3][PATCH " Bruno Larsen via Gdb-patches
2022-09-05 14:59 ` [PINGv4][PATCH " Bruno Larsen via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bkrklqr8.fsf@redhat.com \
--to=gdb-patches@sourceware.org \
--cc=aburgess@redhat.com \
--cc=blarsen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox