From: Tom Tromey <tom@tromey.com>
To: Philippe Waroquiers <philippe.waroquiers@skynet.be>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFAv2 3/3] Make symtab.c better styled.
Date: Thu, 17 Jan 2019 22:25:00 -0000 [thread overview]
Message-ID: <87zhryly7m.fsf@tromey.com> (raw)
In-Reply-To: <20190112222835.16932-4-philippe.waroquiers@skynet.be> (Philippe Waroquiers's message of "Sat, 12 Jan 2019 23:28:35 +0100")
>>>>> "Philippe" == Philippe Waroquiers <philippe.waroquiers@skynet.be> writes:
Philippe> +/* True if MSYMBOL is of some data type. */
Philippe> +
Philippe> +static bool
Philippe> +msymbol_type_data_p (struct bound_minimal_symbol msymbol)
Philippe> +{
Philippe> + return msymbol.minsym
Philippe> + && (MSYMBOL_TYPE (msymbol.minsym) == mst_data
Philippe> + || MSYMBOL_TYPE (msymbol.minsym) == mst_bss
Philippe> + || MSYMBOL_TYPE (msymbol.minsym) == mst_abs
Philippe> + || MSYMBOL_TYPE (msymbol.minsym) == mst_file_data
Philippe> + || MSYMBOL_TYPE (msymbol.minsym) == mst_file_bss);
Philippe> +}
Philippe> +
Philippe> +/* True if MSYMBOL is of some text type. */
Philippe> +
Philippe> +static bool
Philippe> +msymbol_type_text_p (struct bound_minimal_symbol msymbol)
Philippe> +{
Philippe> + return msymbol.minsym
Philippe> + && (MSYMBOL_TYPE (msymbol.minsym) == mst_text
Philippe> + || MSYMBOL_TYPE (msymbol.minsym) == mst_text_gnu_ifunc
Philippe> + || MSYMBOL_TYPE (msymbol.minsym) == mst_data_gnu_ifunc
Philippe> + || MSYMBOL_TYPE (msymbol.minsym) == mst_slot_got_plt
Philippe> + || MSYMBOL_TYPE (msymbol.minsym) == mst_solib_trampoline
Philippe> + || MSYMBOL_TYPE (msymbol.minsym) == mst_file_text);
Philippe> +}
I think these would be better as (const) methods on minsym.
Philippe> + if (msymbol_type_data_p (msymbol))
Philippe> return;
This could then be
if (msymbol.msymbol->data_p ())
Tom
next prev parent reply other threads:[~2019-01-17 22:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-12 22:28 [RFAv2 0/3] Have GDB " Philippe Waroquiers
2019-01-12 22:28 ` [RFAv2 1/3] Use function_name_style to print Ada and C function names Philippe Waroquiers
2019-01-17 22:21 ` Tom Tromey
2019-01-19 12:11 ` Philippe Waroquiers
2019-01-26 6:21 ` Joel Brobecker
2019-01-26 11:04 ` Philippe Waroquiers
2019-01-29 20:34 ` Philippe Waroquiers
2019-01-12 22:28 ` [RFAv2 2/3] Use address style to print addresses in breakpoint information Philippe Waroquiers
2019-01-12 22:28 ` [RFAv2 3/3] Make symtab.c better styled Philippe Waroquiers
2019-01-17 22:25 ` Tom Tromey [this message]
2019-02-07 18:58 ` Pedro Alves
2019-02-09 10:36 ` Philippe Waroquiers
2019-02-12 13:27 ` Pedro Alves
2019-02-12 14:04 ` Ulrich Weigand
2019-02-12 14:32 ` Pedro Alves
[not found] <20190212145443.E2799D8028D@oc3748833570.ibm.com>
2019-02-12 15:53 ` Pedro Alves
2019-02-12 18:41 ` Philippe Waroquiers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhryly7m.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=philippe.waroquiers@skynet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox