Re: [RFAv2 3/3] Make symtab.c better styled.

[Philippe Waroquiers <philippe.waroquiers@skynet.be>]

On Tue, 2019-02-12 at 15:53 +0000, Pedro Alves wrote:
> On 02/12/2019 02:54 PM, Ulrich Weigand wrote:
> > Pedro Alves wrote:
> > 
> > > So the question becomes a simple cosmetic one.  In this case:
> > > 
> > > >   (gdb) info variables
> > > >   [...]
> > > >   Non-debugging symbols:
> > > >   0x0000000010020088  main
> > > 
> > > Should "main" be printed with function style, or variable style.
> > > This basically affects the color used to print the symbol.
> > > 
> > > In Philippe's patch, we'd print it in variable style.  If we used
> > > msymbol_is_function instead of his "is text symbol" check, we'd
> > > print it in function style.
> > 
> > Ah, I see.  I guess that doesn't really matter that much at this
> > point.  Since we're already showing it under "variables" we might
> > as well use the variable style.  But in the end either way would
> > be fine with me ...
> 
> OK, in that case, let's just use with Philippe already has.
Thanks for the review and discussion.
With all this + the feedback of Joel
(in https://sourceware.org/ml/gdb-patches/2019-01/msg00560.html
that confirmed that the ada-lang.c code will effectively use
function style only to style function names), I am assuming
I can push the series (I will retest before that).

Thanks

Philippe