From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21546 invoked by alias); 17 Jan 2019 22:25:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14408 invoked by uid 89); 17 Jan 2019 22:24:43 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,TIME_LIMIT_EXCEEDED autolearn=unavailable version=3.3.2 spammy= X-HELO: gateway33.websitewelcome.com Received: from gateway33.websitewelcome.com (HELO gateway33.websitewelcome.com) (192.185.145.23) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 17 Jan 2019 22:24:24 +0000 Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway33.websitewelcome.com (Postfix) with ESMTP id 0BE8016DA65 for ; Thu, 17 Jan 2019 16:24:14 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id kG58ghmJOiQerkG58g2Iv6; Thu, 17 Jan 2019 16:24:14 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=x4JApQYDZhZq7mKDKJ7AIRdaUVj9VZsiXMPMWjXZ9J4=; b=tUqYwdK8rBMlwV2Lg1AsJIab1C obR2sf6QBt9TYdTIqG7jLowd+E0eZHA71Ax31k/k5OxeW67H2S8Gfxdjaiz9xyvWjTO+1jaDeJ7GW FmTIcp7IbLsp6yopDlopvxUwq; Received: from 75-166-72-210.hlrn.qwest.net ([75.166.72.210]:47840 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gkG57-000P0Q-Q1; Thu, 17 Jan 2019 16:24:13 -0600 From: Tom Tromey To: Philippe Waroquiers Cc: gdb-patches@sourceware.org Subject: Re: [RFAv2 3/3] Make symtab.c better styled. References: <20190112222835.16932-1-philippe.waroquiers@skynet.be> <20190112222835.16932-4-philippe.waroquiers@skynet.be> Date: Thu, 17 Jan 2019 22:25:00 -0000 In-Reply-To: <20190112222835.16932-4-philippe.waroquiers@skynet.be> (Philippe Waroquiers's message of "Sat, 12 Jan 2019 23:28:35 +0100") Message-ID: <87zhryly7m.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-01/txt/msg00417.txt.bz2 >>>>> "Philippe" == Philippe Waroquiers writes: Philippe> +/* True if MSYMBOL is of some data type. */ Philippe> + Philippe> +static bool Philippe> +msymbol_type_data_p (struct bound_minimal_symbol msymbol) Philippe> +{ Philippe> + return msymbol.minsym Philippe> + && (MSYMBOL_TYPE (msymbol.minsym) == mst_data Philippe> + || MSYMBOL_TYPE (msymbol.minsym) == mst_bss Philippe> + || MSYMBOL_TYPE (msymbol.minsym) == mst_abs Philippe> + || MSYMBOL_TYPE (msymbol.minsym) == mst_file_data Philippe> + || MSYMBOL_TYPE (msymbol.minsym) == mst_file_bss); Philippe> +} Philippe> + Philippe> +/* True if MSYMBOL is of some text type. */ Philippe> + Philippe> +static bool Philippe> +msymbol_type_text_p (struct bound_minimal_symbol msymbol) Philippe> +{ Philippe> + return msymbol.minsym Philippe> + && (MSYMBOL_TYPE (msymbol.minsym) == mst_text Philippe> + || MSYMBOL_TYPE (msymbol.minsym) == mst_text_gnu_ifunc Philippe> + || MSYMBOL_TYPE (msymbol.minsym) == mst_data_gnu_ifunc Philippe> + || MSYMBOL_TYPE (msymbol.minsym) == mst_slot_got_plt Philippe> + || MSYMBOL_TYPE (msymbol.minsym) == mst_solib_trampoline Philippe> + || MSYMBOL_TYPE (msymbol.minsym) == mst_file_text); Philippe> +} I think these would be better as (const) methods on minsym. Philippe> + if (msymbol_type_data_p (msymbol)) Philippe> return; This could then be if (msymbol.msymbol->data_p ()) Tom