From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: Tom Tromey <tromey@adacore.com>,
gdb-patches@sourceware.org, Tom Tromey <tom@tromey.com>
Subject: Re: [PATCH] Fix crash in cp_print_value_fields
Date: Tue, 18 Jun 2019 15:35:00 -0000 [thread overview]
Message-ID: <87zhmekiso.fsf@tromey.com> (raw)
In-Reply-To: <d7a187c4-df58-88b7-5763-003447aae181@suse.de> (Tom de Vries's message of "Tue, 18 Jun 2019 15:50:29 +0200")
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
>> + cp_print_static_field (TYPE_FIELD_TYPE (type, i),
>> + v, stream, recurse + 1,
>> + options);
>> + }
Tom> Here options is used ...
>> catch (const gdb_exception_error &ex)
>> {
>> fprintf_filtered (stream,
>> _("<error reading variable: %s>"),
>> ex.what ());
>> }
>> -
>> - cp_print_static_field (TYPE_FIELD_TYPE (type, i),
>> - v, stream, recurse + 1, opts);
Tom> while here opts used to be used.
Tom> Is this change intentional? It's not mentioned anywhere.
Thanks for catching that. It was not intentional. I'll send a fix shortly.
Tom
next prev parent reply other threads:[~2019-06-18 15:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-17 20:18 Tom Tromey
2019-05-29 15:34 ` Tom Tromey
2019-05-29 19:20 ` Pedro Alves
2019-06-18 15:34 ` Tom Tromey
2019-06-18 13:50 ` Tom de Vries
2019-06-18 15:35 ` Tom Tromey [this message]
2019-08-02 15:14 ` [8.3 backport] " Tom de Vries
2019-08-02 17:27 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhmekiso.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox