From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 63677 invoked by alias); 18 Jun 2019 15:35:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 63563 invoked by uid 89); 18 Jun 2019 15:35:55 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:655 X-HELO: gateway22.websitewelcome.com Received: from gateway22.websitewelcome.com (HELO gateway22.websitewelcome.com) (192.185.46.156) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 18 Jun 2019 15:35:53 +0000 Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway22.websitewelcome.com (Postfix) with ESMTP id 23ABD47B0 for ; Tue, 18 Jun 2019 10:35:52 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id dG9IhN3mt2qH7dG9IhXAv3; Tue, 18 Jun 2019 10:35:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=q2h+0IizSa0T2N1ERcvw2a2gt+BCChhBxM080DMi1uw=; b=G0pPecyb3ag+DM3nUZNrrQ0y8q 8OIETKUU49trpbELWP3cu+98R9jy/fv8UdK1Sk6ryO0TnW0Ne20oramJQjBtYdTsYkWzu/uukw2Pi Dd9G58FDO81jZV6ds9dkZOBoC; Received: from 75-166-12-78.hlrn.qwest.net ([75.166.12.78]:41660 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1hdG9H-0028s6-Ti; Tue, 18 Jun 2019 10:35:52 -0500 From: Tom Tromey To: Tom de Vries Cc: Tom Tromey , gdb-patches@sourceware.org, Tom Tromey Subject: Re: [PATCH] Fix crash in cp_print_value_fields References: <20190517201814.27951-1-tromey@adacore.com> Date: Tue, 18 Jun 2019 15:35:00 -0000 In-Reply-To: (Tom de Vries's message of "Tue, 18 Jun 2019 15:50:29 +0200") Message-ID: <87zhmekiso.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-06/txt/msg00339.txt.bz2 >>>>> "Tom" == Tom de Vries writes: >> + cp_print_static_field (TYPE_FIELD_TYPE (type, i), >> + v, stream, recurse + 1, >> + options); >> + } Tom> Here options is used ... >> catch (const gdb_exception_error &ex) >> { >> fprintf_filtered (stream, >> _(""), >> ex.what ()); >> } >> - >> - cp_print_static_field (TYPE_FIELD_TYPE (type, i), >> - v, stream, recurse + 1, opts); Tom> while here opts used to be used. Tom> Is this change intentional? It's not mentioned anywhere. Thanks for catching that. It was not intentional. I'll send a fix shortly. Tom