From: Tom Tromey <tom@tromey.com>
To: Alan Hayward <Alan.Hayward@arm.com>
Cc: Tom Tromey <tom@tromey.com>,
"gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>,
nd <nd@arm.com>
Subject: Re: [PATCH] AArch64: Allow additional sizes in prologue
Date: Tue, 06 Aug 2019 13:52:00 -0000 [thread overview]
Message-ID: <87zhkm9zaf.fsf@tromey.com> (raw)
In-Reply-To: <16866921-5116-49AE-A00E-9D738CE212BD@arm.com> (Alan Hayward's message of "Tue, 6 Aug 2019 08:58:37 +0000")
>>>>> "Alan" == Alan Hayward <Alan.Hayward@arm.com> writes:
Alan> I probably missed that because the correct formatting looks horrible:
Alan> stack.store (pv_add_constant (regs[rn],
Alan> inst.operands[1].addr.offset.imm),
Alan> size, regs[rt]);
This is a pretty normal style you'd see in gdb.
Alan> Instead, I can update it to the following
Alan> stack.store (
Alan> pv_add_constant (regs[rn], inst.operands[1].addr.offset.imm),
Alan> size, regs[rt]);
gdb doesn't normally use the trailing open paren style like that.
Tom
prev parent reply other threads:[~2019-08-06 13:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190805124152.26127-1-alan.hayward@arm.com>
2019-08-05 17:43 ` Tom Tromey
2019-08-06 8:58 ` Alan Hayward
2019-08-06 9:56 ` Richard Earnshaw (lists)
2019-08-06 12:18 ` Alan Hayward
2019-08-14 15:03 ` Alan Hayward
2019-08-06 13:52 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhkm9zaf.fsf@tromey.com \
--to=tom@tromey.com \
--cc=Alan.Hayward@arm.com \
--cc=gdb-patches@sourceware.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox