From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30204 invoked by alias); 6 Aug 2019 13:52:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30194 invoked by uid 89); 6 Aug 2019 13:52:29 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway34.websitewelcome.com Received: from gateway34.websitewelcome.com (HELO gateway34.websitewelcome.com) (192.185.149.222) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 06 Aug 2019 13:52:28 +0000 Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway34.websitewelcome.com (Postfix) with ESMTP id E2B178B9AC for ; Tue, 6 Aug 2019 08:52:25 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id uzt3hZuvMiQeruzt3hxVnI; Tue, 06 Aug 2019 08:52:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=jJHbGiUrYzRL1dHcfNcFlEyShvsXkiriP++hHf5iaBo=; b=PkGPmLMuNYdfsKVYQhVCW2VBAw Mkoy/Sd4tZQrC8OT4IiPRWYrg7j/vqKcIyCAhwC6Am+qrGLU5ogagWZLnq0OoFgOCltwoB4/A/sb8 9zYTKvUTbJ9e7XbcHLlpPFj+r; Received: from 97-122-178-82.hlrn.qwest.net ([97.122.178.82]:51670 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1huzt3-001S6h-Jy; Tue, 06 Aug 2019 08:52:25 -0500 From: Tom Tromey To: Alan Hayward Cc: Tom Tromey , "gdb-patches\@sourceware.org" , nd Subject: Re: [PATCH] AArch64: Allow additional sizes in prologue References: <20190805124152.26127-1-alan.hayward@arm.com> <8736ifcxu8.fsf@tromey.com> <16866921-5116-49AE-A00E-9D738CE212BD@arm.com> Date: Tue, 06 Aug 2019 13:52:00 -0000 In-Reply-To: <16866921-5116-49AE-A00E-9D738CE212BD@arm.com> (Alan Hayward's message of "Tue, 6 Aug 2019 08:58:37 +0000") Message-ID: <87zhkm9zaf.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-08/txt/msg00135.txt.bz2 >>>>> "Alan" == Alan Hayward writes: Alan> I probably missed that because the correct formatting looks horrible: Alan> stack.store (pv_add_constant (regs[rn], Alan> inst.operands[1].addr.offset.imm), Alan> size, regs[rt]); This is a pretty normal style you'd see in gdb. Alan> Instead, I can update it to the following Alan> stack.store ( Alan> pv_add_constant (regs[rn], inst.operands[1].addr.offset.imm), Alan> size, regs[rt]); gdb doesn't normally use the trailing open paren style like that. Tom