Re: [PATCH v2 03/11] Adjust gdb.base/exitsignal.exp for MinGW, separate program names

[Thiago Jung Bauermann <thiago.bauermann@linaro.org>]

I have just one nit, with two instances in this patch and another
instance in another patch.

Pedro Alves <pedro@palves.net> writes:

> diff --git a/gdb/testsuite/gdb.base/exitsignal.exp b/gdb/testsuite/gdb.base/exitsignal.exp
> index 341197cf0c8..4f4c53e37cb 100644
> --- a/gdb/testsuite/gdb.base/exitsignal.exp
> +++ b/gdb/testsuite/gdb.base/exitsignal.exp
> @@ -23,103 +23,126 @@
>  
>  require {!target_info exists gdb,nosignals}
>  
> -standard_testfile segv.c
> +set testfile "exitsignal"
>  
> -if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile}] } {
> -    return
> -}
> +set exec1 "segv"
> +set srcfile1 ${exec1}.c
> +set binfile1 [standard_output_file ${exec1}]
>  
> -# Run to main.  But, before, change cwd to get the core into the
> -# output directory.
> -set_inferior_cwd_to_output_dir
> +set exec2 "normal"
> +set srcfile2 ${exec2}.c
> +set binfile2 [standard_output_file ${exec2}]
>  
> -if { ![runto_main] } {
> -    return
> +if { [build_executable "failed to build $exec1" ${exec1} "${srcfile1}" \
> +	  {debug}] == -1 } {
> +    return -1

The current style for testcases is to not return any value from
top-level.

>  }
>  
> -# Get the inferior's PID for later.
> -set pid [get_inferior_pid]
> -
> -# Print $_exitsignal.  It should be void now, because nothing
> -# happened.
> -gdb_test "print \$_exitsignal" " = void" \
> -    "\$_exitsignal is void before running"
> -
> -# Just to guarantee, making sure that $_exitcode is also void.
> -gdb_test "print \$_exitcode" " = void" \
> -    "\$_exitcode is void before running"
> -
> -# Trigger SIGSEGV.
> -gdb_test "continue" "(Thread .*|Program) received signal SIGSEGV.*" \
> -    "trigger SIGSEGV"
> -
> -if {[istarget "*-*-mingw*"]} {
> -    # We're debugging a pure Win32 program with no SEH handler.  The
> -    # previous continue caught the first-chance exception.  Now we
> -    # catch the second-chance.
> -    gdb_test "continue" "Thread .* received signal SIGSEGV.*" \
> -	"trigger SIGSEGV, second-chance"
> -} elseif {[istarget "*-*-cygwin*"]} {
> -    # Cygwin calls DebugBreak before it lets the process exit.
> -    gdb_test "continue" "Thread .* received signal SIGTRAP.*" \
> -	"trigger try_to_debug SIGTRAP"
> +if { [build_executable "failed to build $exec2" ${exec2} "${srcfile2}" \
> +	  {debug}] == -1} {
> +    return -1

The current style for testcases is to not return any value from
top-level.

-- 
Thiago
(he/him)