Re: [PATCH v2 08/11] Windows gdb+gdbserver: Decode Cygwin ExitProcess codes

[Thiago Jung Bauermann <thiago.bauermann@linaro.org>]

Here's the other instance of the nit.

Pedro Alves <pedro@palves.net> writes:

> diff --git a/gdb/testsuite/gdb.base/exitsignal.exp b/gdb/testsuite/gdb.base/exitsignal.exp
> index 7684646b546..348c7a72eff 100644
> --- a/gdb/testsuite/gdb.base/exitsignal.exp
> +++ b/gdb/testsuite/gdb.base/exitsignal.exp
> @@ -37,6 +37,10 @@ set exec2 "normal"
>  set srcfile2 ${exec2}.c
>  set binfile2 [standard_output_file ${exec2}]
>  
> +set exec3 "segv-win32"
> +set srcfile3 ${exec1}.c
> +set binfile3 [standard_output_file ${exec3}]
> +
>  if { [build_executable "failed to build $exec1" ${exec1} "${srcfile1}" \
>  	  {debug}] == -1 } {
>      return -1
> @@ -47,6 +51,16 @@ if { [build_executable "failed to build $exec2" ${exec2} "${srcfile2}" \
>      return -1
>  }
>  
> +# On Cygwin, also build a pure-Win32 segv binary, used to test that
> +# GDB extracts the terminating SIGSEGV out of the 0xc0000005
> +# (STATUS_ACCESS_VIOLATION) Windows exit code.
> +if {[istarget "*-*-cygwin*"]} {
> +    if { [build_executable "failed to build $exec3" ${exec3} "${srcfile3}" \
> +	      {debug win32}] == -1} {
> +	return -1

The current style for testcases is to not return any value from
top-level.

-- 
Thiago
(he/him)