From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Gdk9CLRpF2owPCEAWB0awg (envelope-from ) for ; Wed, 27 May 2026 18:01:24 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=C57t/2LV; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 1E4A21E024; Wed, 27 May 2026 18:01:24 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9836D1E024 for ; Wed, 27 May 2026 18:01:23 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 298A54BA7990 for ; Wed, 27 May 2026 22:01:23 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 298A54BA7990 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=C57t/2LV Received: from mail-vk1-xa30.google.com (mail-vk1-xa30.google.com [IPv6:2607:f8b0:4864:20::a30]) by sourceware.org (Postfix) with ESMTPS id 120904BA23D8 for ; Wed, 27 May 2026 22:00:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 120904BA23D8 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 120904BA23D8 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::a30 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1779919258; cv=none; b=Cfk9wqrLpBxVl2/q9dRAS4MnZCjsLb5G7UZa47sgLuylAwM8xOilkVNI58yY8k46H4EkJG74+eIZn87zqmh62svXVP14kaEesEEcM/UoiTrLphIahU8P4fYljtoDsNDqUim6j7ITFTzhRhjWdodBskcgEzptDDXEUFWoOBVc2t4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1779919258; c=relaxed/simple; bh=fiMQe7kLlFol8YzjDJ+mcB6AXCh4D84ITlFuPY/jrYg=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=nnrR8gh3b+8Nyz3FCEQC+DPW1rAat8QP4zhOk2jWwWVrIh9D0Wwsb1Es/lZBKJ1BupuZ31r+QyseHyXYUblO/9hzzuWjWPPuzJ6hz6ZfBe8f9ii3lITBKhLZLI+Njbvi8OhFGVWDEKSs6RqHYOKTS/G9guDAa0J9zLFEIjq76FA= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=C57t/2LV DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 120904BA23D8 Received: by mail-vk1-xa30.google.com with SMTP id 71dfb90a1353d-5752b27958fso4173636e0c.1 for ; Wed, 27 May 2026 15:00:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1779919257; x=1780524057; darn=sourceware.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=Cjl/JUo+b1jr+SNBc3yH+gJAxvsykaHiDYK/c4hrhUg=; b=C57t/2LVo/LDgKo/F3c/UFm2JYcHtBqj8OHYyog0Iek1IgYvPPr5svCqX2fyTCkWBV lJwFXbsvhX/ix8p0kyZOEvtN+xDr1vS9W0edXfwRmCJ2ykrFVrIBpi6J6wXZ2erONDO0 bvHw+EbnIVZq9MUA903lmrbjO7KkjZnG+xssElEzMBvkj9bJmO9+ettlY/jsoCb+KQdX xNZLC05YttJuDf4yZwjnrPSZO8Xm9uahRZHctpV7sH53GIb4PhGMQ63nNQgk3VpjfzHd kvD8D1/E6bGNNiHYBVOwTSBsaed93jRT9EoaLhC1xvTHW9TQxiABa/UkilNtzsvA+mSj 5AuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779919257; x=1780524057; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Cjl/JUo+b1jr+SNBc3yH+gJAxvsykaHiDYK/c4hrhUg=; b=ZHFqr0Yh23pT+8t9oG5drUKh3b1WspuEs/V427IWrJCmdlvPGllsNLy8CQF6Mfcbp0 Kxm4H191R6mSF/kn9/MtGk4S2gc77w1xy/A8sZHx4QVdBwqbkJkKT8cJzA8DC5ne/XOd KgKZIr52+tv6BexhHIaI72ughDOPScR+c1iGitzPwF1oCkyVlikStROIygMdy8eHhzdD 1GQcx9roR5gTXlLP6xDD0Xqj18t3mktCKILOIWHBXo3dGsrEwdOpMxHcenhU4ss1UaeB Ez3FqB6dfZ6zSqdtYYPFMLnyedO/tz/JTsvjjl1olDtABdnR1ce18cmbQn2lTBlKWRx1 8TJw== X-Gm-Message-State: AOJu0YwJtZm64oHCJX6z5jW3wbVd6A7jnDjXbtbLWDUl+Aa5Zs5ba4fw 5/k9OxcnGx3/uYSXBjVEWS5QbKhifTi7JJP55Ro8+x3qBSSnQ0OftoB4KUpfn5/WsocvtCBUkBN Wl3JC X-Gm-Gg: Acq92OFi1QyAqD7xnlUhFNHCsxDjWc8VJYQkBSCLIQVuuBBfAeXp6yzQJl7KB+uV1F7 Nn6aCDkirCDAa5JR0xYZknWr5Ob0HbZZ7M23EACQmPav62FmP2K5R3HyeSKeBrrQ3y/WMiviM0A yiBiNzZKgFdZwxQRUoD8ZmciU0rHUtv3Mgs1pb10alO57RWM6O11xJzvCVTm3A+8GH1Pxagxete iLI2o+/2RopgKyNqc1e2TIRKWh7Lyxr4TnWc5vPMZKhWbYPrmGioj/tabvkqeYCk8+c7jpbVeU0 oEDvxlbN+GaQ+yqHSPVehEDJ2+KM9luO4DJ9FHJMd76GA/XRI0V1sEp+V1jPJ3FMmbnRJ1jpKmC Mvjjygd+ctxH1jzeFFX11EbgX7JV8SC/7lffYPTO+0T4pOY4KW9JpcVyDXHM7J8nwBijSUTEAkl aztD2L/ylOn8RiNTSRMDeWJDiKl3COPLvMDWaLrE1hpiwsjJv5AiY/FZY= X-Received: by 2002:a05:6122:3229:b0:56f:a3e2:66a4 with SMTP id 71dfb90a1353d-5865e4a60a0mr14613861e0c.1.1779919257509; Wed, 27 May 2026 15:00:57 -0700 (PDT) Received: from localhost ([2804:14d:7e39:8083:f04c:42e3:5943:38f6]) by smtp.gmail.com with ESMTPSA id a1e0cc1a2514c-96173afb1ecsm18707907241.9.2026.05.27.15.00.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 May 2026 15:00:57 -0700 (PDT) From: Thiago Jung Bauermann To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 08/11] Windows gdb+gdbserver: Decode Cygwin ExitProcess codes In-Reply-To: <20260525191829.984105-9-pedro@palves.net> (Pedro Alves's message of "Mon, 25 May 2026 20:18:26 +0100") References: <20260525191829.984105-1-pedro@palves.net> <20260525191829.984105-9-pedro@palves.net> User-Agent: mu4e 1.14.1; emacs 30.2 Date: Wed, 27 May 2026 19:00:54 -0300 Message-ID: <87tsrs1pih.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Here's the other instance of the nit. Pedro Alves writes: > diff --git a/gdb/testsuite/gdb.base/exitsignal.exp b/gdb/testsuite/gdb.base/exitsignal.exp > index 7684646b546..348c7a72eff 100644 > --- a/gdb/testsuite/gdb.base/exitsignal.exp > +++ b/gdb/testsuite/gdb.base/exitsignal.exp > @@ -37,6 +37,10 @@ set exec2 "normal" > set srcfile2 ${exec2}.c > set binfile2 [standard_output_file ${exec2}] > > +set exec3 "segv-win32" > +set srcfile3 ${exec1}.c > +set binfile3 [standard_output_file ${exec3}] > + > if { [build_executable "failed to build $exec1" ${exec1} "${srcfile1}" \ > {debug}] == -1 } { > return -1 > @@ -47,6 +51,16 @@ if { [build_executable "failed to build $exec2" ${exec2} "${srcfile2}" \ > return -1 > } > > +# On Cygwin, also build a pure-Win32 segv binary, used to test that > +# GDB extracts the terminating SIGSEGV out of the 0xc0000005 > +# (STATUS_ACCESS_VIOLATION) Windows exit code. > +if {[istarget "*-*-cygwin*"]} { > + if { [build_executable "failed to build $exec3" ${exec3} "${srcfile3}" \ > + {debug win32}] == -1} { > + return -1 The current style for testcases is to not return any value from top-level. -- Thiago (he/him)