From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id coRhAmxpF2owPCEAWB0awg (envelope-from ) for ; Wed, 27 May 2026 18:00:12 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=oLUTsros; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id EAC751E0A3; Wed, 27 May 2026 18:00:11 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 238C21E024 for ; Wed, 27 May 2026 18:00:11 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7631D4BA23E2 for ; Wed, 27 May 2026 22:00:10 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7631D4BA23E2 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=oLUTsros Received: from mail-ua1-x92d.google.com (mail-ua1-x92d.google.com [IPv6:2607:f8b0:4864:20::92d]) by sourceware.org (Postfix) with ESMTPS id A94C94BA23D8 for ; Wed, 27 May 2026 21:59:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A94C94BA23D8 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A94C94BA23D8 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::92d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1779919184; cv=none; b=vmEOlDRu1EmnGRfQTVH//RXUSz/wGz2RXq3jH4p0uCh7S3T3z9mSegof90oAuKfp8ywNqR4ly9i77RWqP1A5axwq+Zu2A7K12Kk631RP1tKVdezCyuMDB1z0fEG1zKyS5pmVdEOPON8TYEbRxwoSPHrLnRThAMrA8NBWvnWubZM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1779919184; c=relaxed/simple; bh=Xy0GR7y8McygrFDV6n7Ge96hnr511idEzFtY2y1YXqk=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=TCbfMCvVpZ+sZgZ5QiftlgJuKe4o94IotYMeXnp7a4a/jlkubnRq7vkgNID8g/shvQ7JCHQgRcXaaiKTNuGZWL6i/NTvjSHjOdH/cZrqW/xq6BpfT5mmCizsgUqV6Et0IUEfPuibXbelyO9UQ7NwL+0wziOS/TqsEMtjJ2KqBVg= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=oLUTsros DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A94C94BA23D8 Received: by mail-ua1-x92d.google.com with SMTP id a1e0cc1a2514c-96387977596so349049241.1 for ; Wed, 27 May 2026 14:59:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1779919184; x=1780523984; darn=sourceware.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=W89kEJyxXSD1h4NP9VGkUj4bXWMd6d1sxKAGwLDKs50=; b=oLUTsrosXNm/ddWuTmpy/4I+dZ4oFkAJNY30j2ZNYBLwvOfQBs2C4U4Iqg9pgeit+u 2OlLMxEUWsd4gKp4+sSXoZetIi1u3iMLR23VHEJNpm1TJcrmV4MSZOImACgEikwCLLYk mEzlmZAEabueevw0oF8iiIuYGtXNjxUrSQiNK6DZf9+jcMKcW3Ts9HfMg+Uc0KPL1aop EUkE33mrLm51lXV5qnOTwW5wkRrg28W9mbMoxTrVcxHgDCDYOXlWZkXhxMTSlfsgWUbN dUHv8w//FgQ4ESzrxXV7xkAgW6T5d6+qWUE+hXXn0o7T8W6Qx168b3GXhd/TQZ8YNy9z FR3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779919184; x=1780523984; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=W89kEJyxXSD1h4NP9VGkUj4bXWMd6d1sxKAGwLDKs50=; b=qju6yjGKWEbso2RugEsl10ybK5XvzDgOr61yDK7OFSQwZAJ0P5XnFzFtwtVbkljh97 Dm7smHy0zN6s8IHJKP6Fv1nOdcQwoWmtNYvZ5vkP3djkvEEvBWnQnAcVXmnc42M5my4V HFWfzbOTLycWB1IKlhLA4Rop7UGuMVgh558HKEl+RzlJ6bjgxPK6O5NyL2fSFHchMXlo DEenTl83WAjMzmDs9Sof2g8SfOClrdspHG4zLq6Ps8jEuAV06bPDv1bSz80AZeURbnSP pjMJqJEFu/L6Bgqb/bswxUJQomotW7QOx4YLkr/9pKT7M8Tgoap2ZElYOFQBIdrcEhCO LCSg== X-Gm-Message-State: AOJu0Yy7lcyVPb96wIUhcpZpHYzQsv1BjmIzz4J1aSdPdJvsSoEoqxYa OKhgwF7lGc+GaYDRb4a4s0/UO2xAvZ+Qao3OoWmugKbTHGsYsOuckGxShLd9RuJHBOoMyzn8gvJ SmWz6 X-Gm-Gg: Acq92OFUzPVEWYQewuaeWkR0DWDmCtfyT1JSsF/yhqy6OGYrbmpMvmVjviaroN3D9Xz WRqS5Yr4Jm5XbYr3e9ZKYK851gJtqM17GOmcVNeQZEzTy6mH7A793uHYE6n0RHIuerHCa7ppGrf p8L3gLe12pAvSXyRKJBeck+r8ai1zliTl8kBHkZomwiyBUkcufKfb2m994FYibx/7meIERk46mP 3ln5un+SO7F2vsHMYCo5RItcgoONUh8cmZMSTngbmBMZxpWE+GzmjNjSgPQ91BIxjBA5tW1Z5ky KMVH5OGdyTsT9fkPBLatNhS/1NVSia4rgp2bt46e1iLypRb7BfsMSC3/56zwwauWO2dX6SYjrYf xSkTHQbCM+KpxdZ/mecrrxpXqm2LLrIfndWLH/mxoJvWhls97YrPeH051uo0il9913VTeXGmA2w 713n+9z1LVlXH3Ieu2hCTb/Hc5uMHjNA1TMFr/XtuHZkvq X-Received: by 2002:a05:6102:1590:b0:60f:7499:9b6e with SMTP id ada2fe7eead31-67c854898d4mr11744878137.27.1779919184011; Wed, 27 May 2026 14:59:44 -0700 (PDT) Received: from localhost ([2804:14d:7e39:8083:f04c:42e3:5943:38f6]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-67ff3e499bbsm18454473137.7.2026.05.27.14.59.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 May 2026 14:59:43 -0700 (PDT) From: Thiago Jung Bauermann To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 03/11] Adjust gdb.base/exitsignal.exp for MinGW, separate program names In-Reply-To: <20260525191829.984105-4-pedro@palves.net> (Pedro Alves's message of "Mon, 25 May 2026 20:18:21 +0100") References: <20260525191829.984105-1-pedro@palves.net> <20260525191829.984105-4-pedro@palves.net> User-Agent: mu4e 1.14.1; emacs 30.2 Date: Wed, 27 May 2026 18:59:41 -0300 Message-ID: <87zf1k1pki.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org I have just one nit, with two instances in this patch and another instance in another patch. Pedro Alves writes: > diff --git a/gdb/testsuite/gdb.base/exitsignal.exp b/gdb/testsuite/gdb.base/exitsignal.exp > index 341197cf0c8..4f4c53e37cb 100644 > --- a/gdb/testsuite/gdb.base/exitsignal.exp > +++ b/gdb/testsuite/gdb.base/exitsignal.exp > @@ -23,103 +23,126 @@ > > require {!target_info exists gdb,nosignals} > > -standard_testfile segv.c > +set testfile "exitsignal" > > -if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile}] } { > - return > -} > +set exec1 "segv" > +set srcfile1 ${exec1}.c > +set binfile1 [standard_output_file ${exec1}] > > -# Run to main. But, before, change cwd to get the core into the > -# output directory. > -set_inferior_cwd_to_output_dir > +set exec2 "normal" > +set srcfile2 ${exec2}.c > +set binfile2 [standard_output_file ${exec2}] > > -if { ![runto_main] } { > - return > +if { [build_executable "failed to build $exec1" ${exec1} "${srcfile1}" \ > + {debug}] == -1 } { > + return -1 The current style for testcases is to not return any value from top-level. > } > > -# Get the inferior's PID for later. > -set pid [get_inferior_pid] > - > -# Print $_exitsignal. It should be void now, because nothing > -# happened. > -gdb_test "print \$_exitsignal" " = void" \ > - "\$_exitsignal is void before running" > - > -# Just to guarantee, making sure that $_exitcode is also void. > -gdb_test "print \$_exitcode" " = void" \ > - "\$_exitcode is void before running" > - > -# Trigger SIGSEGV. > -gdb_test "continue" "(Thread .*|Program) received signal SIGSEGV.*" \ > - "trigger SIGSEGV" > - > -if {[istarget "*-*-mingw*"]} { > - # We're debugging a pure Win32 program with no SEH handler. The > - # previous continue caught the first-chance exception. Now we > - # catch the second-chance. > - gdb_test "continue" "Thread .* received signal SIGSEGV.*" \ > - "trigger SIGSEGV, second-chance" > -} elseif {[istarget "*-*-cygwin*"]} { > - # Cygwin calls DebugBreak before it lets the process exit. > - gdb_test "continue" "Thread .* received signal SIGTRAP.*" \ > - "trigger try_to_debug SIGTRAP" > +if { [build_executable "failed to build $exec2" ${exec2} "${srcfile2}" \ > + {debug}] == -1} { > + return -1 The current style for testcases is to not return any value from top-level. -- Thiago (he/him)