From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simon.marchi@ericsson.com>
Cc: Tom Tromey <tom@tromey.com>, <gdb-patches@sourceware.org>
Subject: Re: [RFA 4/6] Change dwarf2_cu::method_info to be a std::vector
Date: Wed, 17 Jan 2018 17:15:00 -0000 [thread overview]
Message-ID: <87y3kwl84m.fsf@tromey.com> (raw)
In-Reply-To: <32a00426-ccdd-858f-85d7-3a2faab54d7f@ericsson.com> (Simon Marchi's message of "Tue, 16 Jan 2018 10:29:01 -0500")
>>>>> "Simon" == Simon Marchi <simon.marchi@ericsson.com> writes:
Simon> On 2018-01-05 07:26 PM, Tom Tromey wrote:
>> This changes the type of dwarf2_cu::method_info and fixes up the uses.
>> In order to remove cleanups from process_full_comp_unit and
>> process_full_type_unit, psymtab_include_file_name also had to be
>> changed to avoid leaving dangling cleanups.
Simon> That seems ok, but I don't completely understand what's happening.
Simon> Can you clarify how process_full_comp_unit/process_full_type_unit are
Simon> related to psymtab_include_file_name? I don't see how the later gets
Simon> called by the formers.
The call chain looks like this:
process_full_comp_unit
-> process_die
-> read_file_scope
-> handle_DW_AT_stmt_list
-> dwarf_decode_lines
-> psymtab_include_file_name
What happened formerly is that process_full_comp_unit installed an outer
cleanup, and then psymtab_include_file_name took advantage of that by
leaving some dangling cleanups.
Tom
next prev parent reply other threads:[~2018-01-17 17:15 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-06 0:26 [RFA 0/6] Some DWARF reader polishing Tom Tromey
2018-01-06 0:26 ` [RFA 5/6] Remove objfile argument from add_dyn_prop Tom Tromey
2018-01-10 13:01 ` Yao Qi
2018-01-10 16:32 ` Tom Tromey
2018-01-16 16:00 ` Yao Qi
2018-01-16 15:33 ` Simon Marchi
2018-01-17 17:16 ` Tom Tromey
2018-01-06 0:26 ` [RFA 4/6] Change dwarf2_cu::method_info to be a std::vector Tom Tromey
2018-01-16 15:30 ` Simon Marchi
2018-01-17 17:15 ` Tom Tromey [this message]
2018-01-17 17:29 ` Simon Marchi
2018-01-06 0:26 ` [RFA 6/6] Remove symbolp typedef Tom Tromey
2018-01-16 15:33 ` Simon Marchi
2018-01-06 0:26 ` [RFA 3/6] Allocate dwarf2_cu with new Tom Tromey
2018-01-10 12:17 ` Yao Qi
2018-01-10 16:14 ` Tom Tromey
2018-01-10 16:28 ` Tom Tromey
[not found] ` <291f71dc-d6cd-f9fa-1da4-f949464eedd0@ericsson.com>
2018-01-17 17:10 ` Tom Tromey
2018-01-06 0:26 ` [RFA 1/6] Unify new_symbol and new_symbol_full Tom Tromey
2018-01-07 5:33 ` Simon Marchi
2018-01-06 0:26 ` [RFA 2/6] Allocate abbrev_table with new Tom Tromey
2018-01-07 5:29 ` Simon Marchi
2018-01-07 16:55 ` Simon Marchi
2018-01-09 18:56 ` Tom Tromey
2018-01-10 12:02 ` Yao Qi
2018-01-10 16:10 ` Tom Tromey
2018-01-10 12:45 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y3kwl84m.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox