From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 96199 invoked by alias); 17 Jan 2018 17:15:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 96032 invoked by uid 89); 17 Jan 2018 17:15:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway22.websitewelcome.com Received: from gateway22.websitewelcome.com (HELO gateway22.websitewelcome.com) (192.185.46.234) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 17 Jan 2018 17:15:18 +0000 Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway22.websitewelcome.com (Postfix) with ESMTP id E65E8102C2 for ; Wed, 17 Jan 2018 11:15:06 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id brIoewOMCzzFjbrIoedUaZ; Wed, 17 Jan 2018 11:15:06 -0600 Received: from 71-218-90-63.hlrn.qwest.net ([71.218.90.63]:46360 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1ebrIo-002cOB-LR; Wed, 17 Jan 2018 11:15:06 -0600 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , Subject: Re: [RFA 4/6] Change dwarf2_cu::method_info to be a std::vector References: <20180106002621.21099-1-tom@tromey.com> <20180106002621.21099-5-tom@tromey.com> <32a00426-ccdd-858f-85d7-3a2faab54d7f@ericsson.com> Date: Wed, 17 Jan 2018 17:15:00 -0000 In-Reply-To: <32a00426-ccdd-858f-85d7-3a2faab54d7f@ericsson.com> (Simon Marchi's message of "Tue, 16 Jan 2018 10:29:01 -0500") Message-ID: <87y3kwl84m.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Source-L: No X-Exim-ID: 1ebrIo-002cOB-LR X-Source-Sender: 71-218-90-63.hlrn.qwest.net (pokyo) [71.218.90.63]:46360 X-Source-Auth: tom+tromey.com X-Email-Count: 5 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-SW-Source: 2018-01/txt/msg00349.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> On 2018-01-05 07:26 PM, Tom Tromey wrote: >> This changes the type of dwarf2_cu::method_info and fixes up the uses. >> In order to remove cleanups from process_full_comp_unit and >> process_full_type_unit, psymtab_include_file_name also had to be >> changed to avoid leaving dangling cleanups. Simon> That seems ok, but I don't completely understand what's happening. Simon> Can you clarify how process_full_comp_unit/process_full_type_unit are Simon> related to psymtab_include_file_name? I don't see how the later gets Simon> called by the formers. The call chain looks like this: process_full_comp_unit -> process_die -> read_file_scope -> handle_DW_AT_stmt_list -> dwarf_decode_lines -> psymtab_include_file_name What happened formerly is that process_full_comp_unit installed an outer cleanup, and then psymtab_include_file_name took advantage of that by leaving some dangling cleanups. Tom