From: Simon Marchi <simon.marchi@ericsson.com>
To: Tom Tromey <tom@tromey.com>, <gdb-patches@sourceware.org>
Subject: Re: [RFA 5/6] Remove objfile argument from add_dyn_prop
Date: Tue, 16 Jan 2018 15:33:00 -0000 [thread overview]
Message-ID: <3c36963b-9b5b-e17c-e908-a286eb9e6467@ericsson.com> (raw)
In-Reply-To: <20180106002621.21099-6-tom@tromey.com>
On 2018-01-05 07:26 PM, Tom Tromey wrote:
> The objfile argument to add_dyn_prop is redundant, so this patch
> removes it.
>
> 2018-01-05 Tom Tromey <tom@tromey.com>
>
> * gdbtypes.h (add_dyn_prop): Remove objfile parameter.
> * gdbtypes.c (add_dyn_prop): Remove objfile parameter.
> (create_array_type_with_stride): Update.
> * dwarf2read.c (set_die_type): Update.
Hi Tom,
> @@ -2305,13 +2304,13 @@ get_dyn_prop (enum dynamic_prop_node_kind prop_kind, const struct type *type)
>
> void
> add_dyn_prop (enum dynamic_prop_node_kind prop_kind, struct dynamic_prop prop,
> - struct type *type, struct objfile *objfile)
> + struct type *type)
> {
> struct dynamic_prop_list *temp;
>
> gdb_assert (TYPE_OBJFILE_OWNED (type));
>
> - temp = XOBNEW (&objfile->objfile_obstack, struct dynamic_prop_list);
> + temp = XOBNEW (&TYPE_OBJFILE (type)->objfile_obstack, struct dynamic_prop_list);
This line is now too long.
Otherwise, LGTM.
Simon
next prev parent reply other threads:[~2018-01-16 15:33 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-06 0:26 [RFA 0/6] Some DWARF reader polishing Tom Tromey
2018-01-06 0:26 ` [RFA 6/6] Remove symbolp typedef Tom Tromey
2018-01-16 15:33 ` Simon Marchi
2018-01-06 0:26 ` [RFA 5/6] Remove objfile argument from add_dyn_prop Tom Tromey
2018-01-10 13:01 ` Yao Qi
2018-01-10 16:32 ` Tom Tromey
2018-01-16 16:00 ` Yao Qi
2018-01-16 15:33 ` Simon Marchi [this message]
2018-01-17 17:16 ` Tom Tromey
2018-01-06 0:26 ` [RFA 4/6] Change dwarf2_cu::method_info to be a std::vector Tom Tromey
2018-01-16 15:30 ` Simon Marchi
2018-01-17 17:15 ` Tom Tromey
2018-01-17 17:29 ` Simon Marchi
2018-01-06 0:26 ` [RFA 1/6] Unify new_symbol and new_symbol_full Tom Tromey
2018-01-07 5:33 ` Simon Marchi
2018-01-06 0:26 ` [RFA 2/6] Allocate abbrev_table with new Tom Tromey
2018-01-07 5:29 ` Simon Marchi
2018-01-07 16:55 ` Simon Marchi
2018-01-09 18:56 ` Tom Tromey
2018-01-10 12:02 ` Yao Qi
2018-01-10 16:10 ` Tom Tromey
2018-01-10 12:45 ` Simon Marchi
2018-01-06 0:26 ` [RFA 3/6] Allocate dwarf2_cu " Tom Tromey
2018-01-10 12:17 ` Yao Qi
2018-01-10 16:14 ` Tom Tromey
2018-01-10 16:28 ` Tom Tromey
[not found] ` <291f71dc-d6cd-f9fa-1da4-f949464eedd0@ericsson.com>
2018-01-17 17:10 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c36963b-9b5b-e17c-e908-a286eb9e6467@ericsson.com \
--to=simon.marchi@ericsson.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox