From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 37303 invoked by alias); 16 Jan 2018 15:33:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 37277 invoked by uid 89); 16 Jan 2018 15:33:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=prop X-HELO: sesbmg22.ericsson.net Received: from sesbmg22.ericsson.net (HELO sesbmg22.ericsson.net) (193.180.251.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 16 Jan 2018 15:32:54 +0000 Received: from ESESSHC009.ericsson.se (Unknown_Domain [153.88.183.45]) by sesbmg22.ericsson.net (Symantec Mail Security) with SMTP id A4.72.27591.32B1E5A5; Tue, 16 Jan 2018 16:32:51 +0100 (CET) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.45) with Microsoft SMTP Server (TLS) id 14.3.352.0; Tue, 16 Jan 2018 16:32:51 +0100 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [100.94.230.5] (129.192.64.65) by AMSPR07MB312.eurprd07.prod.outlook.com (2a01:111:e400:802f::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.428.9; Tue, 16 Jan 2018 15:32:49 +0000 Subject: Re: [RFA 5/6] Remove objfile argument from add_dyn_prop To: Tom Tromey , References: <20180106002621.21099-1-tom@tromey.com> <20180106002621.21099-6-tom@tromey.com> From: Simon Marchi Message-ID: <3c36963b-9b5b-e17c-e908-a286eb9e6467@ericsson.com> Date: Tue, 16 Jan 2018 15:33:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20180106002621.21099-6-tom@tromey.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MWHPR03CA0040.namprd03.prod.outlook.com (2603:10b6:301:3b::29) To AMSPR07MB312.eurprd07.prod.outlook.com (2a01:111:e400:802f::24) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5db4dc2c-1963-476e-7544-08d55cf666ec X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(4534125)(4602075)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060)(7193020);SRVR:AMSPR07MB312; X-Microsoft-Exchange-Diagnostics: 1;AMSPR07MB312;3:gjdUKB8tojTpJXwoLp8ui8Id3hHEqV6ksFaryvlCPu37tfJpKDToZjq1sewR2usI2BCt/WAZk2zwuTTbilZVpKQRLF++FnWZOtBkZ9O0EBxWPeAMjjuR8JkW1xkzSB8VuesIkQBHjRALyIsQp0Y6eGPXb3UZSyfg0yiSLzV0od0dYM93OilY1U59xp8tcsmlcjmN6LLgorifwPdHfyZDIlb7acnMHin8wjo+g/UvpoPziTr/PqsrRv5zHt2Sabn4;25:iwXqQkjkVZ4uQ3zOE6YygclF1yRmrwKyVZ9rDJuL942A+bLr8RrQfEX4ddvMWCw/1CIj9/4Eosq7oCe91XsJ6ghdLaVvzUVQ6vKQzIeyPJVZWh1ByCh9MR99XIoPPCVKmF3kZYAmkq/JaFt5LnisE7RMUsD7TMw0AYd9YLLPzZVknh33wz2WbsidrydIVCYYIE2A9ABrU6QQM4xkIR9ImawJ7a8mVamAfSMlR6Ei0lCTyUb/HYx1Vs8KxYd7hOdrTUlSigT84WpMN0ElxqyVOAeMlRTiA56bDX/rWRoHaRwq6tJz8oi17OpRsxBR9A6J4pM/MWwEbpcKvVkTxcq9nw==;31:cSN9uLgah/Q5LNciq5GfBa5G3+bw6s1kUf+GdEn2zJjmBrCxjrQ3PyZRE0NqaP6KKm9gYoeyWmswhLAGhOOMDjGPeqBHpg2q44jfmyrteSAHdK791iYzcd10KWZvKWK156vZysiel6qzNYTc/qOWz/L8JfkBuZ3e/4zypmmihQhPaXMQ6g5WuP4qohwV7xp/CgHhfv4+9M9hw/gC7JHPoYRzCYiEuxRDVLOHrxY+Iyw= X-MS-TrafficTypeDiagnostic: AMSPR07MB312: X-Microsoft-Exchange-Diagnostics: 1;AMSPR07MB312;20:/HbtubI6wqVZffRfHej2jwfpaUb8i5WT47YssyS0ahqeVNsiBZj1kbWOXCANbZex+SaLkwgRTfmtC3LkgCEN43L4d4uruPzwF24/ByFXqlG1rftg5iTNZeHzRrK57dSZCer/m9SMrNLuhW8oGA0TZzTHWWL0WFj55Eq4PrutYGqQb1HsHrBnds4X6LHjNKZr20yhG2l3Y7z9zSneLgKdLmt6V1459OoZrWlTUtC97C1R70WyxS7qNO4fBOuR7yqNUKGBYPRkJRvs4HQvGrZ1Rm2siOF5DNnOoeWGDqhHQ/SykVnce4AJy61PUzKx7l+yd+t1gaROnzm6bHzyyLfvgG3Fe1H0d/snZX8KEAc/czSjNtTHQZi8kT70l3GzmChZerA5eNkgI7s+Rt4RsLyPJAha1lRbxfi+TyISUGcYQ+Y329TTlMtPWdbCNhGgLSgyKHpBZkjouAvxD+vPScUD903PtnYslDDf+iALladW2PnfAfRxWzGQwtjwfARdGYcc;4:MSlLHDx8o3/H/LCAwjwgxpOfx0isZO2wTrP6N4CktYYzdaiUC3hgaAeufr1iTd6oc5iLvzrwYqnbRmalh7r8HxK712Xr91CpJda12k85BZFHgT7mj+8pIj2p1o1PN6ovWoWFZf6ABv7pvIDEElgL/u9A4BVFDdymVYsNVjQGwjwUrE+zXN1liQWQ6PhbCa3bqHy5nE4foksf53aBAIHg6HCmeKWRf5LerOS36siRJ2TEnIi8bBfilrESDv1kPIUe1fZ0MHmkEsHWA0Wh1rpxKg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040470)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(3231023)(944501161)(10201501046)(6041268)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123562045)(20161123564045)(6072148)(201708071742011);SRVR:AMSPR07MB312;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:AMSPR07MB312; X-Forefront-PRVS: 0554B1F54F X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(346002)(376002)(396003)(39380400002)(39860400002)(366004)(24454002)(377424004)(199004)(189003)(6246003)(83506002)(68736007)(25786009)(47776003)(6116002)(386003)(59450400001)(230700001)(305945005)(8676002)(97736004)(31696002)(5660300001)(3846002)(2906002)(52116002)(53546011)(26005)(106356001)(478600001)(6486002)(86362001)(105586002)(49976009)(65806001)(8936002)(66066001)(53936002)(52146003)(2486003)(7736002)(16576012)(6666003)(229853002)(36756003)(65956001)(23676004)(81166006)(81156014)(2950100002)(76176011)(31686004)(16526018)(58126008)(65826007)(316002)(50466002)(64126003)(78286006);DIR:OUT;SFP:1101;SCL:1;SRVR:AMSPR07MB312;H:[100.94.230.5];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtBTVNQUjA3TUIzMTI7MjM6c3piM0FxVG9WSWZvRzlrU0xkTzhta1loV3RS?= =?utf-8?B?UWw4NXJIS084cTg0elJDNjlBUStGdHhRUFlqbERaNWx2U2thQVZHS3AybHRi?= =?utf-8?B?aHVTSnJPUER0TW40YnRCR1NOc2RjWkhSSmUzL0w3eWQvcVVSUzBnNG0vRXM1?= =?utf-8?B?UGZCeDcvcGc3QVg5czEzaGY4enlrSVFHTFZ3Q0tVWk9scUZIUFlYbVdnV2N3?= =?utf-8?B?d3pOVGRRZmNHcWx6eUhqSEJSdEpKakFONmtONXNRTUJtUEJsWURyVU9qL0FF?= =?utf-8?B?bUZraEVMblh0aFkrdThrQnQxME1nV0Jjd0R5dC9rYk1IaHl5TlBaSmNGL2ZT?= =?utf-8?B?T2sxaUtBcHY3eTFSL3QyUk5jK0I2ZmcxT1VLc0FERHlLZnBxZFNuaVdHeDh1?= =?utf-8?B?YnU4Wk1xRTZ1TXk5bldyckl5cnA4T3JXMU5wT0FHYWFuRDM5T2E1SGFUdFB5?= =?utf-8?B?ODFwcmg4UVhLeEc5QW5YTlR6aWFHUlNIYldDQ3ZxRXBqcDJ1WDNRVkg5UDR0?= =?utf-8?B?a1hOVzVvckw3dTR0SFRoOTRYQkhFcVV4VHFEeTIvTnowOTBDZE1IV01STlN1?= =?utf-8?B?M05kbjFSRGZ1b2VOY0ZYZkplK1dYT1lMd0FxRlFucEsvNnBobmhPMnI4bXg1?= =?utf-8?B?b3NULytIYkhGOStvMFZSQU9NSXd4TWtzcTZaSEdEUUpQME9Jc0crcGRmVk04?= =?utf-8?B?dkJraVUyR3MxOGNlOEVZR0NibVRXUWdVNVFMbTBvZC9IVkZhZzBodnJhcFBi?= =?utf-8?B?WFhhcTYzT05FMEJSQjYvWGRyWThoYWRIaFhMaWl6emluRWZHYjVyaTA3QXZB?= =?utf-8?B?YUF3eGNUckg5d29kOGdHS3Exb21BcWRXTXRNNUFrUnhTenhiTk1kQ2MrM0VE?= =?utf-8?B?a0toNEJQcEt3L0JiUXpacnJidWpXeFYvbFYxd0dEQlZITEFGeFlvcWRGRnF0?= =?utf-8?B?R3lQOW9IRzhLOVdUcXdNV1VteDVWWm1XY0VIekVaek9RQWVoVTVqOG1mRTVJ?= =?utf-8?B?VDN3d2pBMzduUDFNUThLcFZXdWhmOWtGTERqd2trNTNiUmZnTXN5L1praVlI?= =?utf-8?B?c3FSRVNQMjE1WWtZakhLUVFjR3pML1lPN3VQcVVLN2RMRS9mTWdtNXFQczFa?= =?utf-8?B?bmVsSVFPblZCTEYvbFBYR2ZoYWhhK0cxV2I4QlU1dFVQam05VGhnbERhbmRw?= =?utf-8?B?OUxxRW9wMGZYYzl2YnFBNk5CdDgrWExBNG1oSTNCT0J3MmxxYnNES0pLYitJ?= =?utf-8?B?Mkx4ekVhRnMyTnJCN0JrVWpxRTg2WG5XR0dXRXh2OVpkdTJWNkdEMGNRZ29C?= =?utf-8?B?QXozKzllMWN5aUt3K0I2aGllaGVXWlFtVkJpWEZnaHVUUTRZTCtTdE9hOUxl?= =?utf-8?B?Q1daZDc2RUszNk5jT2lac2F3ZXYvV3FuYmVEMSt5TlkyYWtuQWpVREtqcUtk?= =?utf-8?B?UFpRREJOZ00zbjFnVkoxdWc1Vm4vYk92SzdnSGtRUXlUZE1KaUVZWmZxZy84?= =?utf-8?B?d2VGdTk0WFdCQUZsOTFaTndmTnNzUUVrYVhOR3dyRm94ckZJM2RHaXpWa055?= =?utf-8?B?a2hCL1I0VW9tV056N1BhOW5zZmdHRlVoMFJPbXVySVJEUEtTMjAvRVdYd01L?= =?utf-8?B?VFBVRmN6eDBKZ3RVTjA2RkQwZ0RxRUFyZkViT0VIU0xzQklsc2w3Y2RLZU1R?= =?utf-8?B?U01sdzJCckNIL3RjY0plYWdJanlpTCtEMUR5YnBwc1pxRVRkUjBXVllFWmlo?= =?utf-8?B?UEoyVDRJcFlPOWRoMmJvdmxpTHZEUzNiZjZzNDkzUTZaZ0JlMlE2MWdJSzJn?= =?utf-8?B?bnNtWDIrUGEydGExWVZnN3AwK3dNQy9FbHlYZGNuVFRlczNTTVRNQlNML2lN?= =?utf-8?Q?bKp+euLHqCk0pfbOgkdN8bOCJsaV+y6?= X-Microsoft-Exchange-Diagnostics: 1;AMSPR07MB312;6:Z58z9xXwgEudALNgSIdIGsksMydyq/pznOAD9wiK4cAoAea6LeGO1PAWsBCOjwlftNvxZvqd6wGKmJxHaN1S7a4NKZwZ+Pp2ZlvcdUA6ZnMNDuIckuNXbc7a3K70QuNHexiIbN0GX7KHkrzMMvrS3bR8mG6jK9w6x2YX/td3dcllB/GK/rAjmO6/xyn71QCVkX/lqMofAASIDYY1ZIGvBvvUW2AseifIoCPFajk7qVZgCYoRy/FUVFl/neaVSW1fQjuEqC2m1ePqeWhWfx2rkA0mdE/NHFPkBj8R2U0UyCxdejVi6OcIgO7yFAFFRkT3vRsUxuKlT7nRsJ53GQM58UCHLdvFqPmK/NmfkQgIxdE=;5:IRyl6eof3p+j48hLtxh9qbjqNm407rlrhm+DJJtk3eUVbukK5u9ann4c4/vWP2AnPvn0nKImLEPMGrIdcIWwS26RfFxv08hKqPvBj/O0wmswB3WYVv/H73ViKTqado3wE5TpTKsZa8yEvaH+NY1RJufdLiAbJJu/CLrX2o2p/sk=;24:B+4NQn9tcOKEbg8gfnfPmz9kvzqm9ykO4tYXNaB6pRPcG+eERjKwXXNqPpzpHEeN6YRMrNtQBByQO9EG4B/sVSjhnfVk4Q3adAZnr14/ZP4=;7:vwxn8SIlODx49mY8/YQ2DXpH7EEpKkz01snD1YcZE/MQtKSwlJS4ydjiiYnvjrbRWUKfc6vSkZ8fFdsx2EIAIR/4SeH3nCXg5hGeN8rZ0UproAvU8nSZ2czd0eITEdIE0ZTeMp6jlHtbfgGY6Jn/RbTHVfM/SW6u2MIjLwrFavklvR2hAfWyitgW82o9Bs17i85/DWySdYOL/J8KDDfq9DlIam8bSXqYhnlWyFl03pB+T1Wptts31yfoxJQ2r2/0 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jan 2018 15:32:49.0494 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5db4dc2c-1963-476e-7544-08d55cf666ec X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: AMSPR07MB312 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2018-01/txt/msg00300.txt.bz2 On 2018-01-05 07:26 PM, Tom Tromey wrote: > The objfile argument to add_dyn_prop is redundant, so this patch > removes it. > > 2018-01-05 Tom Tromey > > * gdbtypes.h (add_dyn_prop): Remove objfile parameter. > * gdbtypes.c (add_dyn_prop): Remove objfile parameter. > (create_array_type_with_stride): Update. > * dwarf2read.c (set_die_type): Update. Hi Tom, > @@ -2305,13 +2304,13 @@ get_dyn_prop (enum dynamic_prop_node_kind prop_kind, const struct type *type) > > void > add_dyn_prop (enum dynamic_prop_node_kind prop_kind, struct dynamic_prop prop, > - struct type *type, struct objfile *objfile) > + struct type *type) > { > struct dynamic_prop_list *temp; > > gdb_assert (TYPE_OBJFILE_OWNED (type)); > > - temp = XOBNEW (&objfile->objfile_obstack, struct dynamic_prop_list); > + temp = XOBNEW (&TYPE_OBJFILE (type)->objfile_obstack, struct dynamic_prop_list); This line is now too long. Otherwise, LGTM. Simon