From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/3] [gdbsupport] Add gdb::{waitpid,read,write,close}
Date: Fri, 01 Nov 2024 11:35:59 -0600 [thread overview]
Message-ID: <87y122501s.fsf@tromey.com> (raw)
In-Reply-To: <20241028174913.27056-1-tdevries@suse.de> (Tom de Vries's message of "Mon, 28 Oct 2024 18:49:11 +0100")
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
Tom> +namespace gdb {
Tom> +
Tom> +extern "C" {
I didn't even know this was valid ... but is it really needed?
It seems wrong.
Tom> + pid_t
Tom> + waitpid (pid_t pid, int *wstatus, int options)
Tom> + {
Tom> + return gdb::handle_eintr (-1, ::waitpid, pid, wstatus, options);
Tom> + }
Also it seems like these could all be inline functions in the header
anyway.
Tom
next prev parent reply other threads:[~2024-11-01 17:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-28 17:49 Tom de Vries
2024-10-28 17:49 ` [PATCH 2/3] [gdb] Use gdb::waitpid more often Tom de Vries
2024-10-28 17:49 ` [PATCH 3/3] [gdbsupport] Add gdb::wait Tom de Vries
2024-11-01 17:35 ` Tom Tromey [this message]
2024-11-05 12:07 ` [PATCH 1/3] [gdbsupport] Add gdb::{waitpid,read,write,close} Tom de Vries
2024-11-22 16:46 ` Tom de Vries
2024-11-29 16:15 ` Simon Marchi
2024-11-29 16:23 ` Tom de Vries
2024-11-29 16:27 ` Simon Marchi
2024-11-29 16:32 ` Tom de Vries
2024-11-29 17:23 ` Simon Marchi
2024-11-29 17:28 ` Tom de Vries
2024-12-02 9:38 ` Kévin Le Gouguec
2024-12-02 11:07 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y122501s.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox