From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id EanbI5YRJWdDGCIAWB0awg (envelope-from ) for ; Fri, 01 Nov 2024 13:36:22 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=TkOvwltw; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 74F071E359; Fri, 1 Nov 2024 13:36:22 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.5 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE, URIBL_BLOCKED,URIBL_DBL_BLOCKED_OPENDNS autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 16FA01E0C0 for ; Fri, 1 Nov 2024 13:36:22 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9529D3858D33 for ; Fri, 1 Nov 2024 17:36:21 +0000 (GMT) Received: from omta036.useast.a.cloudfilter.net (omta036.useast.a.cloudfilter.net [44.202.169.35]) by sourceware.org (Postfix) with ESMTPS id 2809C3858D29 for ; Fri, 1 Nov 2024 17:36:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2809C3858D29 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2809C3858D29 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1730482565; cv=none; b=nBAa5Crs2f6AbBMWa9EQ+FeXCYF4GW26ESb3nIVTU9Ok/n9rqCHKNwsQ2u4NJ9SKxctf7Fx52eUPKJbLmUX5ymj6RiDFHsuxyrJaRwqGStZytOevhIsgioNWulU33liZ0CHeBiivRnBk3WjoX1275xI+u5yzZmQGGAJIgz2RveU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1730482565; c=relaxed/simple; bh=xz4QzbxFJjxdleL8wnE98gu4vGtbYDxV71fyNKAX8CA=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=Rp1y9PWXRDKXJ+Q3dzp3pnbhTfI1ZHOuV10CeQmO8vdqAJzZQA7LJaqXgnsZlQP5DvN64goYxWPB0l7MRofIBGJMb42XSIC8D2hf+wR6SiVZg5fH8JLfU23W8Bcea7U9l9MBIcue+8Xyr3iioYgl5p3LKX395Nbfgvb5TOdHCCc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6002a.ext.cloudfilter.net ([10.0.30.222]) by cmsmtp with ESMTPS id 6utqtYs1riA196vZ4te5jL; Fri, 01 Nov 2024 17:36:03 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id 6vZ3tU66L65gF6vZ4tic3f; Fri, 01 Nov 2024 17:36:02 +0000 X-Authority-Analysis: v=2.4 cv=Z58nH2RA c=1 sm=1 tr=0 ts=67251182 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=VlfZXiiP6vEA:10 a=ItBw4LHWJt0A:10 a=TkwFQSj7UyJsP7YIULQA:9 a=6Ogn3jAGHLSNbaov7Orx:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=fqDPH1l3ux42LoqEVCRx4DnF500YMw7NhJQTCW0JQpk=; b=TkOvwltwlCk6Bcxq66cAF1yv7+ iTktHeiAWqYdLNUOg5jgkX7UgGxqmcVOd7hRkdQUukpBVjPqGZ3dj71QQQqcRYgwsokwnh+tHO6eW WxEU1zv3yW5GbamNTKXiHbQDZ; Received: from 97-122-113-155.hlrn.qwest.net ([97.122.113.155]:36346 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1t6vZ3-00273D-0p; Fri, 01 Nov 2024 11:36:01 -0600 From: Tom Tromey To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/3] [gdbsupport] Add gdb::{waitpid,read,write,close} In-Reply-To: <20241028174913.27056-1-tdevries@suse.de> (Tom de Vries's message of "Mon, 28 Oct 2024 18:49:11 +0100") References: <20241028174913.27056-1-tdevries@suse.de> X-Attribution: Tom Date: Fri, 01 Nov 2024 11:35:59 -0600 Message-ID: <87y122501s.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.113.155 X-Source-L: No X-Exim-ID: 1t6vZ3-00273D-0p X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-113-155.hlrn.qwest.net (murgatroyd) [97.122.113.155]:36346 X-Source-Auth: tom+tromey.com X-Email-Count: 12 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfF+bxHVvDQrF+v4FJTMfsBYRY1QeygiMWR8n081VGMHIc8UCpJcTKBs6jmG9fxrPwXFBvp1xau+J6WtIsmCqenkrPPPGrxhZiNf/br7fwT82ugIpEogT RkQQDkq5b1mqPBUiCyxUIhX+z/Y2Jh2RW9s4IsYwsXSXmoDEogtz4/58FgeDD2AeTiwUpZycw6LuyOpNqHhwOhKrsM/hNcqFN5M= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Tom" == Tom de Vries writes: Tom> +namespace gdb { Tom> + Tom> +extern "C" { I didn't even know this was valid ... but is it really needed? It seems wrong. Tom> + pid_t Tom> + waitpid (pid_t pid, int *wstatus, int options) Tom> + { Tom> + return gdb::handle_eintr (-1, ::waitpid, pid, wstatus, options); Tom> + } Also it seems like these could all be inline functions in the header anyway. Tom