Re: [PATCH 1/3] [gdbsupport] Add gdb::{waitpid,read,write,close}

[Tom de Vries <tdevries@suse.de>]

On 11/5/24 13:07, Tom de Vries wrote:
> On 11/1/24 18:35, Tom Tromey wrote:
>>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
>>
>> Tom> +namespace gdb {
>> Tom> +
>> Tom> +extern "C" {
>>
>> I didn't even know this was valid ... but is it really needed?
>> It seems wrong.
>>
> 
> It seemed to work:
> ...
> $ cat test.c
> namespace gdb {
> 
>    extern "C" {
>      int foo (void) { return 1; };
>    }
> }
> 
> $ cat test2.c
> namespace gdb {
>    extern "C" {
>      int foo (void);
>    }
> }
> 
> int
> main (void)
> {
>    return gdb::foo ();
> }
> $ g++ test.c test2.c
> ...
> but the linkage symbol is plain foo:
> ...
> $ nm ./a.out  | grep foo
> 00000000004004c7 T foo
> ...
> 
> So, you're right, this is wrong.
> 
> I seem to have ended up with gdb_waitpid instead of gdb::waitpid in v2, 
> similar to gdb_select, but thinking about it now I slightly prefer 
> gdb::waitpid.  I suppose it doesn't matter that much.
> 

When looking at this again today, it bugged me enough rewrite v2 in the 
gdb::waitpid style.  Committed after retesting.

Thanks,
- Tom

>> Tom> +  pid_t
>> Tom> +  waitpid (pid_t pid, int *wstatus, int options)
>> Tom> +  {
>> Tom> +    return gdb::handle_eintr (-1, ::waitpid, pid, wstatus, 
>> options);
>> Tom> +  }
>>
>> Also it seems like these could all be inline functions in the header
>> anyway.
> 
> Done in v2.  In the case of fnctl, I ended up with a template to handle 
> the variable number of arguments.
> 
> Submitted here ( https://sourceware.org/pipermail/gdb-patches/2024- 
> November/212941.html ).
> 
> Thanks,
> - Tom
>