From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 4lK5Fr61QGe7FzsAWB0awg (envelope-from ) for ; Fri, 22 Nov 2024 11:47:58 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=0rCEVJil; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=jl+Dw5bK; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=0rCEVJil; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=jl+Dw5bK; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 3FB771E25F; Fri, 22 Nov 2024 11:47:58 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 2AF8C1E1CC for ; Fri, 22 Nov 2024 11:47:57 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8D032385AC1B for ; Fri, 22 Nov 2024 16:47:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8D032385AC1B Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=0rCEVJil; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=jl+Dw5bK; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=0rCEVJil; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=jl+Dw5bK Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id 563D73857025 for ; Fri, 22 Nov 2024 16:46:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 563D73857025 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 563D73857025 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1732293967; cv=none; b=CpyHmHMZ4kMG5PgK6vuLWZ0u6331q9LdS+De8ZbrwJ/okC/aSAc8fQvooCIS/Ox2zEEjKk8DPNXIckQFwAgiHD01j+TSVOwajPFbfwaF+S4O1EN2aEhOv9gb76pWAPRxfMe+fHoj28MphMfTtrTbwxgGfEcBb++z+g7sL3D6htI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1732293967; c=relaxed/simple; bh=zU5ei+IsNmOZrVYA5lVcXkDHNrREJ3gDV8z1raiJujU=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:From:To; b=UCrjoLylsV8BI6MEbZyVBqXNQ2u+y+x4BpJhS8s2AN4VhDrhzK2IzWp3RLU0a9GvlZdVGmidKw5QZwL00bVXcx7HSMZ9yvWZd+ZwIcnmi0WKFdTrYDeFB53vP75NTnU4Aav2nMUpTDOhj7OZKSSW0Rf9GzFy31TRjTwDn7YFF6I= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 563D73857025 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 44EDB211AD; Fri, 22 Nov 2024 16:46:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1732293966; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EpINHi6/4Y3IUWd00i52mXiS/xILgSNNuGwmx4accBg=; b=0rCEVJil2AfbCj6+9AeqjUzw0RWC11STUcnOfewWTDtuF0YYhkPBuqgwCOdNztyKIVrH3f TrJv1oh3D9w8I95CLIMkksuYOx3WItX+uDHVJZVKV6HP0ga/BOWZ4Rf7Xf063BlvCyDzZf w7UTHpg0qOnA+K3h53tEcQj+AjbYrr0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1732293966; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EpINHi6/4Y3IUWd00i52mXiS/xILgSNNuGwmx4accBg=; b=jl+Dw5bKCLZyedEasday36rBSTDSz3PgSvEI0OrWn8oUb4yKTJpz3jyf9hp309kW8lTOPx u/oW/jlekmIfcBCg== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1732293966; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EpINHi6/4Y3IUWd00i52mXiS/xILgSNNuGwmx4accBg=; b=0rCEVJil2AfbCj6+9AeqjUzw0RWC11STUcnOfewWTDtuF0YYhkPBuqgwCOdNztyKIVrH3f TrJv1oh3D9w8I95CLIMkksuYOx3WItX+uDHVJZVKV6HP0ga/BOWZ4Rf7Xf063BlvCyDzZf w7UTHpg0qOnA+K3h53tEcQj+AjbYrr0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1732293966; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EpINHi6/4Y3IUWd00i52mXiS/xILgSNNuGwmx4accBg=; b=jl+Dw5bKCLZyedEasday36rBSTDSz3PgSvEI0OrWn8oUb4yKTJpz3jyf9hp309kW8lTOPx u/oW/jlekmIfcBCg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 20DB9138A7; Fri, 22 Nov 2024 16:46:06 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id e9RbBk61QGf4EwAAD6G6ig (envelope-from ); Fri, 22 Nov 2024 16:46:06 +0000 Message-ID: <70b41955-4a06-47db-a467-ef8f24ca030a@suse.de> Date: Fri, 22 Nov 2024 17:46:53 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] [gdbsupport] Add gdb::{waitpid,read,write,close} From: Tom de Vries To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20241028174913.27056-1-tdevries@suse.de> <87y122501s.fsf@tromey.com> <9b20eea0-0f14-47d9-ad7f-39e197d2e521@suse.de> Content-Language: en-US In-Reply-To: <9b20eea0-0f14-47d9-ad7f-39e197d2e521@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.991]; MIME_GOOD(-0.10)[text/plain]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_DN_SOME(0.00)[] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 11/5/24 13:07, Tom de Vries wrote: > On 11/1/24 18:35, Tom Tromey wrote: >>>>>>> "Tom" == Tom de Vries writes: >> >> Tom> +namespace gdb { >> Tom> + >> Tom> +extern "C" { >> >> I didn't even know this was valid ... but is it really needed? >> It seems wrong. >> > > It seemed to work: > ... > $ cat test.c > namespace gdb { > >   extern "C" { >     int foo (void) { return 1; }; >   } > } > > $ cat test2.c > namespace gdb { >   extern "C" { >     int foo (void); >   } > } > > int > main (void) > { >   return gdb::foo (); > } > $ g++ test.c test2.c > ... > but the linkage symbol is plain foo: > ... > $ nm ./a.out  | grep foo > 00000000004004c7 T foo > ... > > So, you're right, this is wrong. > > I seem to have ended up with gdb_waitpid instead of gdb::waitpid in v2, > similar to gdb_select, but thinking about it now I slightly prefer > gdb::waitpid.  I suppose it doesn't matter that much. > When looking at this again today, it bugged me enough rewrite v2 in the gdb::waitpid style. Committed after retesting. Thanks, - Tom >> Tom> +  pid_t >> Tom> +  waitpid (pid_t pid, int *wstatus, int options) >> Tom> +  { >> Tom> +    return gdb::handle_eintr (-1, ::waitpid, pid, wstatus, >> options); >> Tom> +  } >> >> Also it seems like these could all be inline functions in the header >> anyway. > > Done in v2.  In the case of fnctl, I ended up with a template to handle > the variable number of arguments. > > Submitted here ( https://sourceware.org/pipermail/gdb-patches/2024- > November/212941.html ). > > Thanks, > - Tom >